FS#56272 - {devtools} makechrootpkg will run namcap regardless of option -n

Attached to Project: Arch Linux
Opened by elionne (elionne) - Tuesday, 07 November 2017, 22:12 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 06 June 2018, 15:54 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To Eli Schwartz (eschwartz)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:

Makechrootpkg always run namcap at the end of package build process even if option "-n" is not present.

Additional info:
* Devtools version=20170911-2

Steps to reproduce:

Run the following command in PKGBUILD directory:

makechrootpkg -r ~/archlinux/build -c

At the end namcap is run, but "-n" (run namcap) is not present.

Proposed patch:

It seems, their is a missing argument when calling function prepare_chroot line 414. I suggest the following patch:

--- a/makechrootpkg.in 2017-08-13 01:29:24.000000000 +0200
+++ b/makechrootpkg.in 2017-09-12 00:50:56.698358300 +0200
@@ -411,7 +411,7 @@

download_sources "$copydir" "$makepkg_user"

- prepare_chroot "$copydir" "$USER_HOME" "$repack"
+ prepare_chroot "$copydir" "$USER_HOME" "$repack" "$run_namcap"

if arch-nspawn "$copydir" \
--bind="$PWD:/startdir" \
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Wednesday, 06 June 2018, 15:54 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://git.archlinux.org/devtools.git/c ommit/?id=3b725b58434b92e93ff90164fae8d7 6c4761706a
devtools 20180528
Comment by Eli Schwartz (eschwartz) - Wednesday, 08 November 2017, 01:26 GMT
https://lists.archlinux.org/pipermail/arch-projects/2017-September/004631.html
Comment by Nicolas I. (IooNag) - Wednesday, 27 December 2017, 09:13 GMT
Hi, I hit this bug today and found the proposed fix in https://lists.archlinux.org/pipermail/arch-projects/2017-September/thread.html , but the patch has not been merged in devtools release 20171108. Has it been forgotten?

Loading...