FS#56147 - [pango] Thunar 1.6.12 (Xfce 4.12) breaks icon mode, not aligned

Attached to Project: Arch Linux
Opened by DJ (TikityTik) - Sunday, 29 October 2017, 01:16 GMT
Last edited by Jan Alexander Steffens (heftig) - Monday, 30 October 2017, 19:55 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 9
Private No

Details

Description: I updated my system via "sudo pacman -Syu", rebooted, then installed discord and libc++ via AUR. When I opened Thunar, I saw the icons are not filling out columns and rows for most folders, only for Home. I have attached 2 images, a normal looking grid of my home folder and a broken grid of my pictures folder. Thunar didn't display files in a single column like this before the update. This is when you view files as icons.
   2017-10-28-202425_1920x1080_s... (110.1 KiB)
   2017-10-28-201751_1920x1080_s... (165.5 KiB)
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Monday, 30 October 2017, 19:55 GMT
Reason for closing:  Upstream
Additional comments about closing:  https://bugzilla.gnome.org/show_bug.cgi? id=789625
Comment by DJ (TikityTik) - Sunday, 29 October 2017, 01:54 GMT
I just noticed this is happening in Nemo and Nautilus as well, so it's not only Thunar. I do not know what package is causing this issue. But it seems to be that the filenames are causing the issues.
   2017-10-28-212032_1920x1080_s... (328.8 KiB)
Comment by Allan McRae (Allan) - Sunday, 29 October 2017, 02:34 GMT
pango update
Comment by Turbo B (Turbo) - Sunday, 29 October 2017, 14:12 GMT
Same thing using PcmanFM with xfce4 DE ..
   pango-1-40-12.1.png (6.6 KiB)
   pango-1-40-13.1.png (11.7 KiB)
Comment by Lionel Trayne (linuxbeak) - Sunday, 29 October 2017, 16:09 GMT
This is also happening on caja in MATE
Comment by loqs (loqs) - Sunday, 29 October 2017, 16:52 GMT
@Allan the latest PKGBUILD in trunk is for_commit=377b6e7e853a05715e1a53f0739042eb23418da7 # tags/1.40.13^0 which contains the issue?

git bisect start
# bad: [377b6e7e853a05715e1a53f0739042eb23418da7] 1.40.13
git bisect bad 377b6e7e853a05715e1a53f0739042eb23418da7
# good: [fd429398a64bc2d7a01da64efa736bbb6eec6a29] 1.40.12
git bisect good fd429398a64bc2d7a01da64efa736bbb6eec6a29
# good: [c53d56212a3491ea3eeb49f7e38391eb95dfe671] testiter: Don't leak PangoFontDescriptions
git bisect good c53d56212a3491ea3eeb49f7e38391eb95dfe671
# good: [0d14052d719274e586176280b3c98dd54fcf8764] PangoLayoutIter: Allocate an array of Extents instead of a linked list
git bisect good 0d14052d719274e586176280b3c98dd54fcf8764
# bad: [c4619480e536e393e2d4a8e26a6ceb5af1fe80e3] Update pango_default_break function for Line Break
git bisect bad c4619480e536e393e2d4a8e26a6ceb5af1fe80e3
# good: [7721b0bed57038b342655220ad9bc32f4599f174] PangoLayout: Optimize pango_layout_get_baseline
git bisect good 7721b0bed57038b342655220ad9bc32f4599f174
# first bad commit: [c4619480e536e393e2d4a8e26a6ceb5af1fe80e3] Update pango_default_break function for Line Break

Reverting c4619480e536e393e2d4a8e26a6ceb5af1fe80e3 resolves the issue on this system
Edit:
Upstream commit was a fix for this bug report https://bugzilla.gnome.org/show_bug.cgi?id=788115
Edit2:
New opened upstream bug report https://bugzilla.gnome.org/show_bug.cgi?id=789625
Comment by loqs (loqs) - Monday, 30 October 2017, 19:37 GMT
@JCG and @hetfig could you push a new release with c4619480e536e393e2d4a8e26a6ceb5af1fe80e3 reverted until upstream resolves the issue?
This would restore the relevant behaviour from 1.40.12 but keep all the other changes.
Comment by Jan Alexander Steffens (heftig) - Monday, 30 October 2017, 19:54 GMT
https://bugzilla.gnome.org/show_bug.cgi?id=789625

Releasing 1.40.13-2 with revert soon.