FS#55843 - [firefox] Crash reports miss debug symbols

Attached to Project: Arch Linux
Opened by Chih-Hsuan Yen (yan12125) - Monday, 02 October 2017, 17:34 GMT
Last edited by Doug Newgard (Scimmia) - Tuesday, 03 October 2017, 16:04 GMT
Task Type Bug Report
Category Packages: Testing
Status Closed
Assigned To No-one
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
I got reproducible SIGSEGV errors in both Arch-built version and upstream Firefox [1]. In two crash reports generated by the Arch [2] and upstream version [3], only the upstream Firefox one has stack traces. The crash report generated by the Arch version contains only addresses.

I guess crashreporter-symbols.zip is not properly uploaded to https://crash-stats.mozilla.com/symbols/upload?

[1] https://download.mozilla.org/?product=firefox-56.0-SSL&os=linux64&lang=en-US
[2] https://crash-stats.mozilla.com/report/index/73b8df81-9130-42dd-aa6f-e8e871171002
[3] https://crash-stats.mozilla.com/report/index/677bf97d-7ad1-4416-b37c-dfb2b1171002

Additional info:
firefox 56.0-1

Steps to reproduce:
1. Turn e10s off by either setting both browser.tabs.remote.autostart and browser.tabs.remote.autostart.2 to false from about:config or installing an incompatible addons like adblockplus
2. Go to Google Drive and upload an empty file test.txt
3. Wait for some seconds. Either Firefox crashes or uploading hangs. Cancelling and restarting will trigger the crash.

(This occurs with my main account but not with another clean account)

PS. I'm the one who revoked my signoff of Firefox on https://www.archlinux.org/packages/signoffs/. I'm not sure whether a reproducible SIGSEGV can be a blocker from moving a package from [testing] to [extra]. [1] may provide some insights.

[1] https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3Adom%3A%3AFileReaderSync%3A%3AReadAsDataURL
This task depends upon

Closed by  Doug Newgard (Scimmia)
Tuesday, 03 October 2017, 16:04 GMT
Reason for closing:  Fixed
Additional comments about closing:  In trunk
Comment by loqs (loqs) - Monday, 02 October 2017, 18:51 GMT
firefox is not built with debug symbols as is standard practise for arch packages.
the option ac_add_options --enable-debug should add them but
see also https://developer.mozilla.org/en-US/docs/Uploading_symbols_to_Mozillas_symbol_server
Comment by Chih-Hsuan Yen (yan12125) - Tuesday, 03 October 2017, 07:33 GMT
> firefox is not built with debug symbols as is standard practise for arch packages.

Apparently firefox is a special case. After downloading its PKGBUILD and building, there's indeed a file firefox-56.0.en-US.linux-x86_64.crashreporter-symbols.zip.

In PKGBUILD, there's a line |./mach buildsymbols| [1], and the |./upload-symbol-archive| script does exactly what https://crash-stats.mozilla.com/symbols/upload/api/ describes.

I downgraded to extra/firefox (55.0.3) and triggered the same crash. The resultant crash report [3] has debug symbols. So this is a Firefox 56 regression, most likely at the Arch side as the upstream version creates correct crash reports.

[1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/firefox#n129
[2] https://git.archlinux.org/svntogit/packages.git/tree/trunk/upload-symbol-archive?h=packages/firefox
[3] https://crash-stats.mozilla.com/report/index/4937efec-e213-4854-ba7d-4dc861171003
Comment by loqs (loqs) - Tuesday, 03 October 2017, 07:50 GMT
https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/firefox&id=570b8b761c7e18977edea93dd929e1e52c79b628 ?
Comment by Chih-Hsuan Yen (yan12125) - Tuesday, 03 October 2017, 08:07 GMT
Wow that looks the correct fix. Thanks and looking forward for the new symbol package.

Loading...