FS#55565 - [android-tools] boringssl upstream dependency is not stable

Attached to Project: Community Packages
Opened by Henry Tung (compgamer89) - Saturday, 09 September 2017, 16:09 GMT
Last edited by Eli Schwartz (eschwartz) - Sunday, 10 September 2017, 03:06 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The current build for android-tools has a floating dependency on the boringssl Git repo. This means that the build is not stable, i.e. changes to the repo risk changing/breaking past builds. The intro note in the boringssl repo suggests this might happen without warning. Since boringssl is statically linked into the build, any changes would affect the packaged code directly.

Would recommend fixing to this version [https://android.googlesource.com/platform/external/boringssl/+/android-8.0.0_r4/BORINGSSL_REVISION] and syncing version in correspondence to that.

Additional info:
* 8.0.0_r4-2
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Sunday, 10 September 2017, 03:06 GMT
Reason for closing:  Fixed
Additional comments about closing:  in trunk, will apply on next update
Comment by Eli Schwartz (eschwartz) - Sunday, 10 September 2017, 02:02 GMT
Anything should be fine, as long as the PKGBUILD specifies the #commit=... it is built against.
Comment by Anatol Pomozov (anatolik) - Sunday, 10 September 2017, 02:22 GMT
Thank you, it makes sense. The fix got merged as r256718.
Comment by Eli Schwartz (eschwartz) - Sunday, 10 September 2017, 02:54 GMT
Is this a no-op commit because that is the version it was built with anyway, or something that only applies for the next package update?
Comment by Anatol Pomozov (anatolik) - Sunday, 10 September 2017, 02:56 GMT
adb seems work fine now so no need to push a new revision now. This commit will be applied to the next android-tools version.

Loading...