FS#55536 - [xmms2] Creates user with UID 46, reserved for mopidy

Attached to Project: Community Packages
Opened by Josh Beach (jtmb) - Wednesday, 06 September 2017, 13:37 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 10 January 2018, 13:58 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Xmms2 in community repo creates a user xmms2 with UID 46 which is reserved for mopidy in Arch UID Database.

Please see here:

https://github.com/mopidy/mopidy/issues/1596

And here:

https://wiki.archlinux.org/index.php/UID_and_GID_List

This user is also not removed on uninstall.


https://git.archlinux.org/svntogit/community.git/tree/trunk/install.sh?h=packages/xmms2

Diff removing the post-uninstall userdel: https://git.archlinux.org/svntogit/community.git/commit/trunk/install.sh?h=packages/xmms2&id=e8092d955f53f17e705f8c3bb5113d352ecff92b




Additional info:
* package version(s)
0.8DrO_o.882.g942b17f-2

* config and/or log files etc.


Steps to reproduce:

Install xmms2.

Install mopidy.

Run mopidyctl or mopidy.service through systemd.

Mopidy fails due to system user not having been created.
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Wednesday, 10 January 2018, 13:58 GMT
Reason for closing:  Fixed
Additional comments about closing:  xmms2 0.8DrO_o.949.gca15e830-8 as part of a general repo cleanup
Comment by Josh Beach (jtmb) - Wednesday, 06 September 2017, 13:46 GMT
also present in latest version 0.8DrO_o.949.gca15e830-4

Sorry I didn't bracket [xmms2] in title.
Comment by Sergej Pupykin (sergej) - Thursday, 07 September 2017, 09:20 GMT
Please try xmms2-0.8DrO_o.949.gca15e830-5
Comment by Josh Beach (jtmb) - Sunday, 10 September 2017, 04:59 GMT
Installed successfully and issues are resolved as far as I can tell.
Comment by Eli Schwartz (eschwartz) - Sunday, 10 September 2017, 06:05 GMT
Really, the directory should be created via tmpfiles.d and the user should be created via sysusers.d

The current setup means that the package will have a mismatch with what is in the actual filesystem.
Comment by loqs (loqs) - Wednesday, 13 September 2017, 17:54 GMT
@eschwartz something like this?
Comment by Eli Schwartz (eschwartz) - Thursday, 14 September 2017, 00:09 GMT
Yes, except that you forgot to remove the line in the PKGBUILD that created /var/lib/xmms2/ owned as root. So you'd still have a mismatch, you just move it from post_install to tmpfiles.d

Also setting !emptydirs in makepkg.conf would cause this package as it currently is to not work properly. Another reason to move to sysusers.d/tmpfiles.d
Comment by loqs (loqs) - Thursday, 14 September 2017, 08:53 GMT
The tmpfiles.d entry adjusts the permissions on /var/lib/xmms2/ if it already exists so technically no mismatch.
As you pointed out though it is redundant. Thank you for the review.
Comment by Eli Schwartz (eschwartz) - Thursday, 14 September 2017, 18:39 GMT
The mismatch is that pacman -Qkk would report modified ownership...

Loading...