FS#55477 - [python-tensorflow] 1.3.0-2 running "rm -rf" on /contrib/tensorboard removes a needed dependency
Attached to Project:
Community Packages
Opened by Göktay Kaykusuz (goktay.kaykusuz) - Saturday, 02 September 2017, 12:53 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 09 September 2017, 10:38 GMT
Opened by Göktay Kaykusuz (goktay.kaykusuz) - Saturday, 02 September 2017, 12:53 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 09 September 2017, 10:38 GMT
|
Details
Description:
While running the PKGBUILD, the script removes a necessary part of the Tensorflow. Even though Google have removed tensorboard from the tensorflow repo, /tensorflow/contrib/tensorboard is still referenced from elsewhere. For example, "/tensorflow/contrib/keras/python/keras/callbacks.py" tries to access tensorboard by looking it inside of /tensorflow/contrib. Please do not meddle with libraries that you do not develop, based on your subjective decisions. Reading "I don't know what kind of sense that makes but we have to clean it out from this pacakge." after 2 hours of search is not a good experience. "rm -rf ${pkgdir}/usr/lib/python3.6/site-packages/tensorflow/contrib/tensorboard" should be removed from the PKGBUILD. Steps to reproduce: 1) Open up python interactive shell 2) Write "import tensorflow.contrib" |
This task depends upon
Closed by Sven-Hendrik Haase (Svenstaro)
Saturday, 09 September 2017, 10:38 GMT
Reason for closing: Fixed
Saturday, 09 September 2017, 10:38 GMT
Reason for closing: Fixed
They have removed tensorboard to a new repo but they still have a copy(?) inside contrib folder AND they still have scripts that call tensorboard from contrib.
I don't know why there are duplicates but nevertheless, deleting it causes problems.
Pardon me for my attitude, I was just frustrated.
Have a nice day.
https://github.com/tensorflow/tensorflow/issues/12841
Although they have moved tensorboard to a new repo, inside contrib folder there still have folder call tensorboard And It's still depended by:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/keras/python/keras/callbacks.py#L34
So, i think it is not a good idea to remove folder /tensorflow/contrib/tensorboard
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/tensorflow#n118
Here is the relevant part of the wheel tree (the bug tracker messes up the formatting a bit):
tensorflow
└── contrib
└── tensorboard
├── graph_explorer
│ ├── __init__.py
│ └── proto
│ ├── graph_explorer_pb2.py
│ └── __init__.py
├── __init__.py
└── plugins
├── __init__.py
├── projector
│ ├── __init__.py
│ └── projector_config_pb2.py
└── trace
├── __init__.py
├── trace_info_pb2.py
└── trace.py
[1] https://pypi.python.org/pypi/tensorflow/1.3.0
Great, thanks for your effort