FS#55477 - [python-tensorflow] 1.3.0-2 running "rm -rf" on /contrib/tensorboard removes a needed dependency

Attached to Project: Community Packages
Opened by Göktay Kaykusuz (goktay.kaykusuz) - Saturday, 02 September 2017, 12:53 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 09 September 2017, 10:38 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Description:

While running the PKGBUILD, the script removes a necessary part of the Tensorflow. Even though Google have removed tensorboard from the tensorflow repo, /tensorflow/contrib/tensorboard is still referenced from elsewhere. For example, "/tensorflow/contrib/keras/python/keras/callbacks.py" tries to access tensorboard by looking it inside of /tensorflow/contrib.

Please do not meddle with libraries that you do not develop, based on your subjective decisions. Reading "I don't know what kind of sense that makes but we have to clean it out from this pacakge." after 2 hours of search is not a good experience.

"rm -rf ${pkgdir}/usr/lib/python3.6/site-packages/tensorflow/contrib/tensorboard" should be removed from the PKGBUILD.



Steps to reproduce:

1) Open up python interactive shell
2) Write "import tensorflow.contrib"
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Saturday, 09 September 2017, 10:38 GMT
Reason for closing:  Fixed
Comment by Göktay Kaykusuz (goktay.kaykusuz) - Saturday, 02 September 2017, 15:19 GMT
Actually, while thinking I have realized that your side of the problem was a small oversight. The major fault is on tensorflow github.
They have removed tensorboard to a new repo but they still have a copy(?) inside contrib folder AND they still have scripts that call tensorboard from contrib.
I don't know why there are duplicates but nevertheless, deleting it causes problems.

Pardon me for my attitude, I was just frustrated.
Have a nice day.
Comment by Göktay Kaykusuz (goktay.kaykusuz) - Saturday, 02 September 2017, 19:30 GMT
  • Field changed: Percent Complete (100% → 0%)
This issue was NOT a duplicate. I was talking about an addition that came in with the 1.3.0-2 and you have closed it by referencing an unrelated issue...
Comment by yanlin (godspeed) - Wednesday, 06 September 2017, 15:21 GMT
I encountered the same issue as:
https://github.com/tensorflow/tensorflow/issues/12841

Although they have moved tensorboard to a new repo, inside contrib folder there still have folder call tensorboard And It's still depended by:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/keras/python/keras/callbacks.py#L34

So, i think it is not a good idea to remove folder /tensorflow/contrib/tensorboard
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/tensorflow#n118
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 07 September 2017, 18:02 GMT
I didn't just randomly decide to remove this. I removed it because I got file conflicts between both packages. I'll see whether I can instead remove a subset.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 07 September 2017, 18:06 GMT
By the way @goktay.kaykusuz keep in mind that we are all volunteers here so if you are not happy about how slowly I fix this in my spare time (and keep in mind the building tensorflow takes a good amount of time) then I invite you to become TU and take over the package. This is not me being offended, this is an actual option I invite you to explore.
Comment by Ben Wolsieffer (lopsided98) - Friday, 08 September 2017, 01:50 GMT
If you look inside the wheel available on PyPi [1], you can see that a few files are still included in the tensorboard directory, so these are probably the files that should be retained in this package.

Here is the relevant part of the wheel tree (the bug tracker messes up the formatting a bit):

tensorflow
└── contrib
   └── tensorboard
      ├── graph_explorer
      │   ├── __init__.py
      │   └── proto
      │   ├── graph_explorer_pb2.py
      │   └── __init__.py
      ├── __init__.py
      └── plugins
      ├── __init__.py
      ├── projector
      │   ├── __init__.py
      │   └── projector_config_pb2.py
      └── trace
      ├── __init__.py
      ├── trace_info_pb2.py
      └── trace.py

[1] https://pypi.python.org/pypi/tensorflow/1.3.0
Comment by Sven-Hendrik Haase (Svenstaro) - Friday, 08 September 2017, 12:03 GMT
Ok, please test the current tensorboard + python-tensorflow.
Comment by Ben Wolsieffer (lopsided98) - Friday, 08 September 2017, 18:19 GMT
python-tensorflow works for me, but python-tensorflow-cuda does not.
Comment by Sven-Hendrik Haase (Svenstaro) - Saturday, 09 September 2017, 07:58 GMT
Ok cool. Will rebuild the cuda package then (was an oversight) and close this issue then.
Comment by Sven-Hendrik Haase (Svenstaro) - Saturday, 09 September 2017, 09:41 GMT
Alright, please test the new set of packages. They also now have the pycaches to speed up importing.
Comment by yanlin (godspeed) - Saturday, 09 September 2017, 10:21 GMT
python-tensorflow-cuda works for me
Great, thanks for your effort

Loading...