Arch Linux

Description:

Using symlinks in /etc/initcpio/* to another part of the filesystem causes mkinitcpio to warn with confusing messages like: "Hook 'modconf' is deprecated. Replace it with 'modconf' in your config".

I encountered this due to the use of a central system config store that installs symlinks to itself throughout the system. I was also shadowing an existing hook, hence my error message mentioning "modconf".

Steps to reproduce:
1. ln -s /dev/null /etc/initcpio/install/
2. mkinitcpio -L
3. Observe deprecated "null" warning.

See attached for a patch addressing the warning when both the source and destination file are the same, which makes for useless messages. This does not address the case where the symlink points outside of the folder but to a filename different than the symlink's name; perhaps a check for slashes in the link target or that the resolved path still points inside of the same directory (or one of initcpio dirs) should be used instead.