FS#55180 - [wpa_actiond] Wait for three "failed" PONGs before disconnecting

Attached to Project: Arch Linux
Opened by Emil (xexaxo) - Thursday, 17 August 2017, 14:23 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 24 January 2018, 18:59 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

On certain workloads my system can get really low on memory and available fds.
This leads to select() returning 0, which gets interpreted as "wpa_supplicant is dead".

The attached patch reworks that to disconnect from the network, after three such attempts.
In practise only one retry seems sufficient on my setup.

I've been running the patch for 2 months and tried sending it to archlinux-projects ML but it got rejected even with the [wpa_actiond] prefix :-\

My patch could be completely bonkers, so any suggestions how to address this correctly will be appreciated.
   0001-Wait-for-three-failed-PO... (2.6 KiB)
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Wednesday, 24 January 2018, 18:59 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://git.archlinux.org/wpa_actiond.gi t/commit/?id=8b74c8b3f69e501560e5f0c25cb cbc4aefcbc0ed
Comment by Eli Schwartz (eschwartz) - Thursday, 17 August 2017, 15:36 GMT
  • Field changed: Category (Packages: Core → Arch Projects)
The mailing list doesn't reject mail just because it lacks a prefix, but it *is* subscribers-only... have you subscribed? :)
Comment by Emil (xexaxo) - Thursday, 17 August 2017, 17:00 GMT
Yes, I am subscribed.
You're right though - I'm merely guessing why the email got rejected. The reply does say anything on the topic :-\
Comment by Eli Schwartz (eschwartz) - Tuesday, 29 August 2017, 06:10 GMT
By the way, I was wrong -- arch-projects does indeed filter emails that lack a valid prefix, but it is the only list that does that. See https://paste.xinu.at/nlZoe/ for the filter rules.

wpa_actiond is not on that list, so use the generic [projects]
Comment by Emil (xexaxo) - Wednesday, 24 January 2018, 18:08 GMT
Props to Bartłomiej, the patch was merged and updated package 1.4-3 was released.

Loading...