Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#55175 - Single- and double-click behavior is inconsistent in GTK3 file chooser

Attached to Project: Arch Linux
Opened by Zhuoyun Wei (wzyboy) - Thursday, 17 August 2017, 06:43 GMT
Last edited by Eli Schwartz (eschwartz) - Thursday, 17 August 2017, 14:20 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Since this upstream commit https://git.gnome.org/browse/gtk%2B/commit/?id=fb0a13b7f070a14312dafa1e4df6ba03cf33be01 , the single- and double-click behavior became inconsistent and unpredictable. A lot of bug reports has been opened upstream, in various StackExchange posts, and in Arch Linux forum:

https://bugzilla.gnome.org/show_bug.cgi?id=758065 (see the long list of "duplicates")
https://bbs.archlinux.org/viewtopic.php?id=212278
https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1519778

The commit in question was authored in 2015 but the behavior starts to effect more users (me included) when Chromium / Google Chrome starts to link against the affected version of GTK3. I get annoyed by this confusing behavior on a daily basis every time I upload a file on a web page.

Many users would like the commit to be reverted (see above links) but still the GTK / GNOME dev team do nothing. So good guys in Ubuntu team patched this:

--- gtk+3.0-3.18.7.orig/gtk/gtkfilechooserwidget.c
+++ gtk+3.0-3.18.7/gtk/gtkfilechooserwidget.c
@@ -2401,7 +2401,10 @@ list_button_press_event_cb (GtkWidget
gdk_device_get_source (device) == GDK_SOURCE_TOUCHSCREEN;

get_selection_modifiers (widget, event, &modify, &extend);
- if (!is_touchscreen &&
+ /* Ubuntu, disable the new behaviour of opening sometime on single click
+ it's confusing for users and the change had no rational
+ https://launchpad.net/bugs/1519778 */
+ if (FALSE && !is_touchscreen &&
!modify && !extend &&
event->type == GDK_BUTTON_PRESS &&
event->button == GDK_BUTTON_PRIMARY &&


I have tested this patch on extra/gtk3-3.22.15. It still works. The behavior of file chooser in Chrome is predictable again after the patch. Could Arch Linux please add the patch, as well?
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Thursday, 17 August 2017, 14:20 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Arch does not revert upstream features, even if we disagree with the feature.
Comment by Eli Schwartz (eschwartz) - Thursday, 17 August 2017, 14:19 GMT
I don't see why we should do this, it is kind of the definition of Arch Linux that we don't casually patch upstream just because we disagree with them.

If gtk3 sucks and upstream does silly things that the majority of users dislike, then, well, that's really nothing new IMHO. Maybe you can convince the Chromium team to move to some decent GUI toolkit like Qt5.

Meanwhile, the upstream bug report you linked has a bunch of people who actually like this feature, but think the implementation needs to be changed (which is what that bug is actually about). So from the perspective of upstream, you would actually be asking us to "revert a feature that wasn't actually ready to be merged to master yet".

Loading...