FS#55064 - [gitlab-gitaly] Adapt gitaly-ruby

Attached to Project: Community Packages
Opened by Jonas Hahnfeld (hahnjo) - Monday, 07 August 2017, 17:11 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Thursday, 10 August 2017, 21:10 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Version 0.26.0 introduced `gitaly-ruby` in config.toml (see https://gitlab.com/gitlab-org/gitaly/commit/0c32842c37e5f41a1d427312f390963237ab57fa). I think this should be adapted to `/opt/ruby2.3/`?

(Somehow related: 0.29.0 has just added `gitlab-shell` which should probably be set to `/usr/share/webapps/gitlab-shell/`)
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Thursday, 10 August 2017, 21:10 GMT
Reason for closing:  Fixed
Comment by Sven-Hendrik Haase (Svenstaro) - Tuesday, 08 August 2017, 21:12 GMT
I updated to 0.29.0 and integrated your suggestions. Please have a look at the current package and tell me whether it looks good to you.
Comment by Jonas Hahnfeld (hahnjo) - Thursday, 10 August 2017, 08:40 GMT
I still see gitaly-ruby with upstream defaults:

[gitaly-ruby]
# The directory where gitaly-ruby is installed
dir = "/home/git/gitaly/ruby"
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 10 August 2017, 12:46 GMT
Oh! It appears we have miscommunicated. I change ruby/bin/gitlab-ruby to be interpreted with ruby-2.3 instead. I didn't understand what the gitaly-ruby thing was. It's not actually just an interpreter. It's more like a sideprocess to the main go thing to help them run ruby things because their ruby code base is so large that they can't port it all to go.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 10 August 2017, 12:49 GMT
Should be good in rel -3.

Loading...