FS#55001 - [electron] [caprine] clicking URLs doesn't work

Attached to Project: Community Packages
Opened by Asbjørn Apeland (aude) - Tuesday, 01 August 2017, 13:06 GMT
Last edited by Nicola Squartini (tensor5) - Monday, 04 September 2017, 11:38 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Nicola Squartini (tensor5)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Clicking URLs in Caprine doesn't work, it results in an error.

Error message:
"TypeError: URL is not a constructor (at index.js:265)"
https://i.imgur.com/eR24r0E.png

This happens because the "url" Node.js native module has been updated, and Caprine uses the newer version.
https://github.com/sindresorhus/caprine/blob/711c24dd41ff9642f6e366760f0b7e14e3569066/index.js#L265

Bug will be fixed when updating Electron.


Additional info:
* caprine 2.6.0-1
* electron 1.4.16-3 (comes with node 6.5.0)
* https://stackoverflow.com/q/44738065


Steps to reproduce:

0. Open Caprine
1. Open a conversation with a link
2. Click the link
This task depends upon

Closed by  Nicola Squartini (tensor5)
Monday, 04 September 2017, 11:38 GMT
Reason for closing:  Fixed
Additional comments about closing:  Updated Electron
Comment by Asbjørn Apeland (aude) - Tuesday, 01 August 2017, 13:07 GMT
This bug might be more appropriate to assign to [electron]. Feel free to re-assign.
Comment by Nicola Squartini (tensor5) - Sunday, 13 August 2017, 16:30 GMT
This will be fixed once I upgrade electron, hopefully soon :)
Comment by Nicola Squartini (tensor5) - Thursday, 31 August 2017, 10:38 GMT
Can you upgrade caprine and electron and let me know if the problem persists?
Comment by Asbjørn Apeland (aude) - Monday, 04 September 2017, 10:06 GMT
Updated caprine and electron, both seem to be working fine. Clicking URLs works :)

Thanks!

Loading...