FS#54513 - [miniupnpd] Please also enable backup of the miniupnpd scripts under /etc

Attached to Project: Community Packages
Opened by Eric Wang (enihcam) - Monday, 19 June 2017, 08:26 GMT
Last edited by Toolybird (Toolybird) - Tuesday, 04 April 2023, 03:19 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Please also enable backup of the miniupnpd scripts under /etc. My upnp init scripts was wiped. :(

Additional info:
* package version(s)
* config and/or log files etc.


Steps to reproduce:
This task depends upon

Closed by  Toolybird (Toolybird)
Tuesday, 04 April 2023, 03:19 GMT
Reason for closing:  Fixed
Additional comments about closing:  '-w' was added by upstream long ago.
Comment by Levente Polyak (anthraxx) - Wednesday, 09 May 2018, 23:14 GMT
which script exactly did you change? and what exactly did you do with that?
the sh scripts shouldn't really be changed and are for iptables stuff etc.
Comment by Eric Wang (enihcam) - Wednesday, 09 May 2018, 23:29 GMT
The background is that I have another service that updates iptables and starts in parallel with miniupnpd.
The change i made is simply add '-w' option in $IPTABLES to wait for the lock.

If you didn't like to backup the .sh files, that would be fine if you could patch miniupnpd_functions.sh by adding '-w' in $IPTABLES.

Maybe I can file a feature request to upstream to ask for adding 'iptable_extra_option=' in miniupnpd.conf
Comment by Levente Polyak (anthraxx) - Thursday, 10 May 2018, 00:25 GMT
i think it would be a good idea to get something upstreamed to support this. we should not fiddle downstream to make this somehow work.
If you can file a request, that would be brilliant

Loading...