FS#54487 - [calibre] New content server in calibre 3.0 requires python2-msgpack

Attached to Project: Community Packages
Opened by Bastian Beranek (totsilence) - Saturday, 17 June 2017, 08:44 GMT
Last edited by Jelle van der Waa (jelly) - Monday, 19 June 2017, 17:44 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

The new content server in calibre 3.0 (enabled by clicking "Preferences -> Sharing over the net -> Start server") requires python2-msgpack to be installed.

I think the package should at least be an optional dependencies of calibre?
This task depends upon

Closed by  Jelle van der Waa (jelly)
Monday, 19 June 2017, 17:44 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 3.0.0-2
Comment by Tim (freaz) - Sunday, 18 June 2017, 00:53 GMT
It should be a required dependency. A built in feature won't work without it.
Comment by Doug Newgard (Scimmia) - Sunday, 18 June 2017, 01:29 GMT
"built in feature" means nothing. The main functionality of the program works without it, so optional would be fine.
Comment by Eli Schwartz (eschwartz) - Sunday, 18 June 2017, 05:18 GMT
By that logic, several other things should be an optional dependency as well. :)

Anyway, I could swear this was one of the things I mentioned to jelle over IRC and he said he was keeping notes on those changes... but promises, promises. :D

3.1.0 will require python2-unrardll BTW, I will be uploading it shortly to the AUR for calibre-git.
Comment by ed tomlinson (edt) - Sunday, 18 June 2017, 14:36 GMT
If you had the content server enabled in a pre 3.0 version calibre will not start at all. It leaves calibre in a state that required you to kill one process and use kill -9 on the other. This alone is a very good reason to add the python2-msgpack to the depends list (and not as optional).

IMHO its fine to require additional packages when upgrade, but not fine to upgrade and then have the application fail due to a missing depends.
Comment by Doug Newgard (Scimmia) - Sunday, 18 June 2017, 14:43 GMT
Pacman would tell you about the new optional dep when you update. That's all that should be needed.
Comment by Jelle van der Waa (jelly) - Monday, 19 June 2017, 11:43 GMT
@eschwartz I know you mentioned a few things, but then life happened..... I couldn't really find upstream which deps changed. But I'll make the changes tonight.
Comment by Eli Schwartz (eschwartz) - Monday, 19 June 2017, 13:15 GMT
There's a trick to it. :) As instructed on https://calibre-ebook.com/download_linux you can see the dependencies, and more importantly the *changes* in dependencies, at https://github.com/kovidgoyal/build-calibre/commits/master/scripts/sources.json

Loading...