FS#54287 - [python-flask] Wrong version number in flask

Attached to Project: Community Packages
Opened by Simon Hanna (simonsmiley) - Saturday, 03 June 2017, 14:36 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 20 September 2017, 16:11 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Flask has the wrong version number. The installed flask says it is '0.12.2-dev' while it should be '0.12.2'. It looks like the github release tarball isn't the same as the one published on pypi. I created an issue upstream https://github.com/pallets/flask/issues/2355
Not sure how it will play out. At one point or another the flask package has to be updated here though
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Wednesday, 20 September 2017, 16:11 GMT
Reason for closing:  Fixed
Additional comments about closing:  python-flask 0.12.2-3
Comment by David (davidism) - Saturday, 03 June 2017, 17:11 GMT
I've uploaded the sdist to the GitHub release. ---I'll adjust our release process to do this in the future too. The URL should be an easy replacement in the PKGBUILD.---
https://github.com/pallets/flask/releases/download/0.12.2/Flask-0.12.2.tar.gz
Comment by David (davidism) - Saturday, 03 June 2017, 17:21 GMT
Scratch that, it was a problem with this release only, the tag should be pointing at the correct commit but got lost somehow. I'm not going to upload sdists to GitHub in the future, I'll leave this one up if you want to use it for this build only.
Comment by David (davidism) - Sunday, 04 June 2017, 01:50 GMT
The tag should now point at the correct commit. Rebuilding with the current PKGBUILD should get you the right archive.
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 14 June 2017, 17:10 GMT
Ok thanks. Rebuilt this.
Comment by Simon Hanna (simonsmiley) - Wednesday, 20 September 2017, 13:05 GMT
I don't think this was properly fixed. The package from community, still shows the old version string. When I did `asp checkout python-flask` I got a PKGBUILD with wrong sha checksums. I think an additional rebuild is necessary
Comment by Eli Schwartz (eschwartz) - Wednesday, 20 September 2017, 13:06 GMT
Looking at the svntogit logs, the pkgrel was updated but not the checksums, so I think this got rebuilt using the old, cached source tarball?
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 20 September 2017, 13:45 GMT
I just made double and tripple sure and even manually downloaded https://github.com/pallets/flask/archive/0.12.2.tar.gz but that package has the same sha512sum as the one in the package. The link by David is a 404.
Comment by Simon Hanna (simonsmiley) - Wednesday, 20 September 2017, 14:32 GMT
The file downloaded from github has
sha256sum flask-0.12.2.tar.gz
7b1306b690c706b0f4054c23bda57565fc050b5736bfd034609c1f26d35bfa28 flask-0.12.2.tar.gz

The pkgbuild I downloaded using `asp checkout python-flask` has sha256sums=('ef3f047ab2af83fc1b9658d8953857f63a84a2fcebcf4e77f8252f0f3e7684f2')

Comment by Doug Newgard (Scimmia) - Wednesday, 20 September 2017, 14:47 GMT
Sven, you updated it to 0.12.2-1: https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/python-flask&id=3c3431a233204354e94fba3b540637ec841a473a
Then you updated it to 0.12.2-2 to fix this bug: https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/python-flask&id=726b5ccbc20b35453da2ded4f80ca74813341553
But if you notice, the checksum on that last commit didn't change. It would appear that 0.12.2-2 was built from the same source as 0.12.2-1. You later changed to using sha512sums and used the checksum for the new file, but it was never rebuilt for that.
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 20 September 2017, 15:14 GMT
Alright, so that basically means that now with the rebuild rel -3 it should be alright.
Comment by Simon Hanna (simonsmiley) - Wednesday, 20 September 2017, 15:39 GMT
Yeah! It's fixed :-)
Comment by Eli Schwartz (eschwartz) - Wednesday, 20 September 2017, 16:11 GMT
Though, for some reason the source url now hardcodes $pkgver...

Loading...