FS#53989 - [gitlab-runner] Version displayed as 'dev'

Attached to Project: Community Packages
Opened by Matt Clarkson (mattyclarkson) - Tuesday, 09 May 2017, 14:32 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Tuesday, 23 May 2017, 18:03 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The version of `gitlab-runner` is reported as `dev` rather than the actual version number

Additional info:
* 9.1.1


Steps to reproduce:
* Install `gitlab-runner`
* Register with a GitLab instance
* Look at the 'runners' page to see the reported version of `gitlab-runner`
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Tuesday, 23 May 2017, 18:03 GMT
Reason for closing:  Fixed
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 10 May 2017, 08:15 GMT
Right. Patches welcome. Frankly I don't know how to fix this.
Comment by Matt Clarkson (mattyclarkson) - Wednesday, 10 May 2017, 08:54 GMT
I was having a look into how they build the upstream patches for the offical Ubuntu/Debian/CentOS/RHEL repositories and I couldn't figure it out either. I have created an upstream issue to get some help:

https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/2444
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 10 May 2017, 09:33 GMT
While we're at it, it would be cool to get  FS#51333  fixed.
Comment by Matt Clarkson (mattyclarkson) - Wednesday, 10 May 2017, 12:27 GMT
I think these are the lines we need:

https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/f335/Makefile#L34-36

Could we use the Makefile to build the project? Otherwise I can look into figuring out how to set the correct LDFLAGS for Go

Loading...