FS#53809 - [libesmtp] Not correctly linked against openssl 1.1

Attached to Project: Community Packages
Opened by Luke Shumaker (lukeshu) - Tuesday, 25 April 2017, 05:28 GMT
Last edited by Andreas Radke (AndyRTR) - Thursday, 22 July 2021, 05:31 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

When libesmtp pkgrel bumped from 4 to 5 for the openssl 1.1 rebuild, it ended up not using openssl at all.

Without an explicit `--with-openssl` argument to `./configure`, it tries to auto-detect whether openssl is available. One of the steps it takes is checking whether there is a "SSL_library_init" symbol in libcrypto.so or libssl.so. However, in openssl 1.1, SSL_library_init is a preprocessor macro, not an actual symbol; so libesmtp's ./configure erroneously thinks that libssl isn't available, and disables openssl support.

Additional info:
* package version(s) libesmtp 1.0.6-5
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Thursday, 22 July 2021, 05:31 GMT
Reason for closing:  Fixed
Additional comments about closing:  libesmtp 1.1.0-1
Comment by Luke Shumaker (lukeshu) - Tuesday, 25 April 2017, 05:34 GMT
Attached is a patch that adds a prepare() function that replaces the check for "SSL_library_init" with "OPENSSL_init_ssl" (the definition of SSL_library_init is "# define SSL_library_init() OPENSSL_init_ssl(0, NULL)").

I have verified that this results in a working libesmtp with STARTTLS; i.e., beyond fixing the ./configure check, it doesn't require any other patching to be compatible with openssl 1.1.

The patch also adds an explicit `--with-openssl` flag to `./configure`, so that if anything like this happens in the future, it will cause a configure error, rather than silently disabling TLS support.
   libesmtp.patch (0.6 KiB)
Comment by Dr. Vogi (DrVogi) - Thursday, 11 May 2017, 02:12 GMT
The attached patch seems to work for me.
Thanks
Comment by Eli Schwartz (eschwartz) - Monday, 19 March 2018, 05:27 GMT
Currently cannot build at all as the upstream website is dead and Fedora juggled around their build infrastructure.
Comment by Luke Shumaker (lukeshu) - Tuesday, 17 July 2018, 04:53 GMT
I believe the correct URLs are now:

url=http://brianstafford.info/libesmtp/
source=(http://brianstafford.info/libesmtp/libesmtp-1.0.6.tar.bz2)

Loading...