FS#53701 - [offlineimap] systemd service file changes

Attached to Project: Community Packages
Opened by benutzer193 (benutzer193) - Tuesday, 18 April 2017, 02:00 GMT
Last edited by Jaroslav Lichtblau (Dragonlord) - Wednesday, 19 April 2017, 05:55 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jaroslav Lichtblau (Dragonlord)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
The current offlineimap update added two new systemd unit files, so the PKGBUILD has to be updated.
See here: https://github.com/OfflineIMAP/offlineimap/tree/master/contrib/systemd

Additional info:
* New files: offlineimap-oneshot.service, offlineimap-oneshot@.service


To fix just add the following lines to the PKGBUILD:

install -Dm644 contrib/systemd/$pkgname-oneshot.service "${pkgdir}"/usr/lib/systemd/user/$pkgname-oneshot.service
install -Dm644 contrib/systemd/$pkgname-oneshot@.service "${pkgdir}"/usr/lib/systemd/user/$pkgname-oneshot@.service
This task depends upon

Closed by  Jaroslav Lichtblau (Dragonlord)
Wednesday, 19 April 2017, 05:55 GMT
Reason for closing:  Implemented
Additional comments about closing:  Implemented in offlineimap-7.1.0-2

I keep the 7 lines until offlineimap installs the files within the install routine, as I like it more than have a wildcard there.
Comment by Doug Newgard (Scimmia) - Tuesday, 18 April 2017, 04:22 GMT
Ug, making it 7 commands that should be one.
Comment by benutzer193 (benutzer193) - Tuesday, 18 April 2017, 07:59 GMT
Yeah was wondering that myself, but perhaps it should be three commands like:

install -Dm644 contrib/systemd/*.service "${pkgdir}"/usr/lib/systemd/user/"
install -Dm644 contrib/systemd/*.timer "${pkgdir}"/usr/lib/systemd/user/"
install -Dm644 contrib/systemd/*.target "${pkgdir}"/usr/lib/systemd/user/"


as you don't want to copy the README and we don't know if there will be added other files in the future which do not belong into the systemd user units folder.
Comment by Doug Newgard (Scimmia) - Tuesday, 18 April 2017, 13:53 GMT
You need to use "-t" to specify the target, but otherwise that works. Even those 3 can be combined into one, contrib/systemd/*.{service,timer,target)
Comment by benutzer193 (benutzer193) - Tuesday, 18 April 2017, 16:01 GMT
Okay, if this is the case the man page is imprecise, but IIRC I did use install without "-t" with the target as the last argument and a dir.
And yeah you could combine it, I don't know why I did not suggest it that way.
Comment by Doug Newgard (Scimmia) - Tuesday, 18 April 2017, 16:23 GMT
The "-t" is only needed if using -D and the dir doesn't already exist.

Loading...