FS#53513 - [devtools] makechrootpkg command does not delete subvolume when using "T" option

Attached to Project: Arch Linux
Opened by Jerome (sinatosk) - Friday, 31 March 2017, 19:36 GMT
Last edited by Jan Alexander Steffens (heftig) - Sunday, 09 April 2017, 00:37 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: makechrootpkg command with "T" option fails due to a directory created by systemd.

I see at line 392 in file /usr/bin/makechrootpkg your doing this

btrfs subvolume delete "$copydir" >/dev/null ||

instead of

subvolume_delete_recursive "$copydir" ||

I then noticed that there were some changes at

https://git.archlinux.org/devtools.git/commit/?id=eec7fcf965763d5395c336f92cd56b193d054947

and I'm assuming it was missed?

Additional info:
* package version(s)
devtools 20170320-1
* config and/or log files etc.
The error

==> Removing temporary copy [iptables]...ERROR: cannot delete '/home/user/tmp/pkgchroot/iptables': Directory not empty
==> ERROR: Unable to delete subvolume /home/user/tmp/pkgchroot/iptables

Steps to reproduce:

this is assuming everything has been setup before this step

- change directory to where the PKGBUILD is
- execute command "makechrootpkg -n -T -r $CHROOT -l iptables"
- after compilation, the error occurs
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Sunday, 09 April 2017, 00:37 GMT
Reason for closing:  Fixed
Comment by Jan Alexander Steffens (heftig) - Sunday, 09 April 2017, 00:37 GMT
Fixed in master, thanks.

Loading...