FS#5316 - [patch] makepkg can't handle sources with space in URL

Attached to Project: Pacman
Opened by Jaroslaw Swierczynski (swiergot) - Wednesday, 30 August 2006, 21:45 GMT
Last edited by James Rayner (iphitus) - Tuesday, 28 November 2006, 12:01 GMT
Task Type Bug Report
Category
Status Closed
Assigned To Aaron Griffin (phrakture)
Architecture not specified
Severity Medium
Priority Normal
Reported Version 0.7.2 Gimmick
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Currently it's not possible to use sources like:

http://stimpyrama.org/data/files/linux/dArch KDM.tar.gz

The attached patch fixes makepkg so that one can write:

source=('http://stimpyrama.org/data/files/linux/dArch KDM.tar.gz')
   makepkg.diff (3.2 KiB)
This task depends upon

Closed by  Aaron Griffin (phrakture)
Tuesday, 05 December 2006, 07:50 GMT
Reason for closing:  Won't implement
Additional comments about closing:  The source URLs this fixes are actually not valid, standard compliant URLs. Spaces should be escaped with %20.
Comment by Jaroslaw Swierczynski (swiergot) - Wednesday, 30 August 2006, 22:01 GMT
Wait, it's not working properly. I'll take a look tommorow.
Comment by Jaroslaw Swierczynski (swiergot) - Thursday, 31 August 2006, 08:20 GMT
Ok, the patch is correct, it was just a buggy PKGBUILD (space after \ in source array). The question is: should we support PKGBUILDs with this bug? Right now the bug just makes makepkg to ignore md5sums array. With my patch makepkg stops. In my opinion we should not support buggy PKGBUILDs because md5sums must be processed. But if for some reason you decide to support this bug, please apply patch attached to this comment. Otherwise the original patch will be just fine.
   makepkg-for-buggy-pkgbuilds.d... (3.3 KiB)

Loading...