FS#52762 - [netdata] [patch] PKGBUILD improvements.

Attached to Project: Community Packages
Opened by Konstantin Shalygin (k0ste) - Sunday, 29 January 2017, 14:41 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 18 December 2017, 11:55 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

1. Add Logrotate configuration from upstream (resolve  FS#52348 ).
2. Add optdepends list plugin dependencies.
3. Backup not only main config, but also plugin confs (leaked from AUR suggestions).
4. Remove chowns from install script. This work carried by systemd-tmpfiles.
5. Remove user creation from install script. This work carried by systemd-sysusers.
6. Support pacman hooks: systemd-{sysusers,tmpfiles} (https://www.archlinux.org/todo/pacman-hooks-systemd-sysuserstmpfiles/).
7. Set capabilities, now apps.plugin works with full force (https://github.com/firehol/netdata/wiki/Apps-Plugin#apps-plugin-is-missing-information).
8. Now user delete after package removed.
9. PKGBUILD now have prepare() function, proper way for configuration.
10. Uses macros where can.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Monday, 18 December 2017, 11:55 GMT
Reason for closing:  Fixed
Comment by Doug Newgard (Scimmia) - Sunday, 29 January 2017, 14:54 GMT
I haven't reviewed, but #8 needs to be removed. See https://www.archlinux.org/todo/usergroup-management/

After a quick review, #2 and #3 might be the only things implemented correctly here. :(
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 24 May 2017, 05:30 GMT
I implemented a safe subset of the changes. Please check it out and lets discuss the rest of them.
Comment by Konstantin Shalygin (k0ste) - Wednesday, 24 May 2017, 05:34 GMT
tmpfiles/sysusers still not used;
configure still not in prepare() section;
no any changes in optdeps;
Comment by Nicolai Syvertsen (saivert) - Monday, 21 August 2017, 16:50 GMT
Could you also add /etc/netdata/stream.conf to backups? This currently gets overwritten on each upgrade.

Loading...