FS#52553 - [freecad] Please correct the Release and Revision # in Help > About FreeCAD

Attached to Project: Community Packages
Opened by Kunda (Kunda) - Saturday, 14 January 2017, 22:47 GMT
Last edited by Laurent Carlier (lordheavy) - Wednesday, 01 March 2017, 19:34 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Florian Pritz (bluewind)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Thanks for maintaining the FreeCAD package. I was hoping it would be possible to correctly represent the fields in the About page (see attached). Essentially both the Revision and Release fields are defined as 'Unknowns'. This would really help the FreeCAD team to troubleshoot bugs more effectively.
Thanks!

Additional info:
* Downstream Manjaro Linux 16.10 Community FreeCAD v0.16-6

Steps to reproduce:
1) Open FreeCAD
2) Click Help > About FreeCAD
   FreeCAD-About.png (177.8 KiB)
This task depends upon

Closed by  Laurent Carlier (lordheavy)
Wednesday, 01 March 2017, 19:34 GMT
Reason for closing:  Upstream
Comment by Kunda (Kunda) - Sunday, 15 January 2017, 15:16 GMT
  • Field changed: Percent Complete (100% → 0%)
That's what I thought, but then I asked (see https://github.com/manjaro/packages-community/issues/249#issuecomment-272657500 ) and it turns out that FreeCAD is an archlinux package.
Comment by Dave Reisner (falconindy) - Sunday, 15 January 2017, 15:19 GMT
...but can you actually reproduce this in Arch Linux? Where does FreeCAD get its Revision and Release information from? ...and why would this be something that needs to be solved at the *distro* level? Isn't freecad itself in the best place to determine its own version?
Comment by Doug Newgard (Scimmia) - Sunday, 15 January 2017, 16:16 GMT
This is something that's usually done by upstream when they make the release tarball.
Comment by Florian Pritz (bluewind) - Monday, 16 January 2017, 14:57 GMT
I don't quite understand why adding that information would be of any use whatsoever. The dialog already displays the version number, but actually it is much better if you check with pacman which package you have. That revision number wouldn't change if we apply any patches or perform other changes during build. You can also find the PKGBUILD we use which shows everything here: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/freecad

Assuming we didn't apply any changes ourselves, you can just look up the tag (version number) in the git repo and you know exactly which source we built since a tag uniquely identifies a specific commit. git even allows you to use the tag instead of a commit id so I really can't understand why the revision number would allow for "more efficient" troubleshooting.

Also as already mentioned by Dave and Doug, this should really be fixed by upstream. I just build their release tarball.
Comment by Kunda (Kunda) - Tuesday, 17 January 2017, 00:29 GMT
Apologies. This is an upstream issue because they compile through git and not the tarballs. version.h isn't getting updated correctly when compiling from tarballs.
I found the issue in the FreeCAD forums:

"See here also: http://forum.freecadweb.org/viewtopic.php?f=4&p=148647 and here: http://forum.freecadweb.org/viewtopic.php?f=4&t=17538
The crux of the matter is if not building with git the packager must handle them version.h themselves."

Loading...