FS#52510 - [gitlab] Multiple errors because of incompatible systemd unit-file options

Attached to Project: Community Packages
Opened by Kovacs Bela (kovacsbe9) - Thursday, 12 January 2017, 14:01 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 16 January 2017, 11:00 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Had an issue when gitlab can not create anything in the /usr/share/webapps/gitlab/tmp folder after updating from a previous version.
It produced a various range of errors in my system:
* Failing startups
* HTTP 500 errors on zip downloads
* HTTP 500 errors when creating new groups
* etc..

Found out it was because "ProtectSystem=full" option was present in the Arch supplied systemd unit files.
The mentioned option make /usr read-only for the running process.

Additionally please see this issue in the upstream forums: https://gitlab.com/gitlab-org/gitlab-workhorse/issues/27
Although the issue is workhorse specific, the root cause persists in the whole Arch gitlab package.

I think removing the mentioned systemd option is not a reasonable solution, it will decrease security.



Additional info:
* gitlab 8.15.3-1 (x86_64)

Steps to reproduce:
After
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Monday, 16 January 2017, 11:00 GMT
Reason for closing:  Not a bug
Comment by Kovacs Bela (kovacsbe9) - Thursday, 12 January 2017, 14:07 GMT
Unfinished description, sorry. The rest is here:

Steps to reproduce:
After installation create a repository, push a commit and try to download a zip file.
The zip download process tries to create a "repositories" subfolder in the "/usr/share/webapps/gitlab/tmp" folder, which fails and gitlab returns HTTP 500.
Comment by Doug Newgard (Scimmia) - Friday, 13 January 2017, 15:55 GMT
This sounds more like a configuration issue. Shared path seems to be set to /var/lib/gitlab/shared in gitlab.yml.
Comment by Kovacs Bela (kovacsbe9) - Monday, 16 January 2017, 08:45 GMT
After investigating i can say that you are right. I had a very old gitlab.yml, it does not even had a shared path setting (e.g. the default value of repository_downloads_path was tmp/repositories relative to the root of the Rails app which is /usr/share/webapps/gitlab).
Pacman did not updated the configuration files as they contained custom values (like the hostname).

This explains the mentioned issues. Sorry for bothering you with this ticket. I think this ticket can be closed now.

Loading...