FS#52029 - [systemd] systemd-nspawn in v232 breaks rkt

Attached to Project: Arch Linux
Opened by Sergiusz Urbaniak (sur) - Friday, 02 December 2016, 14:27 GMT
Last edited by Dave Reisner (falconindy) - Friday, 09 December 2016, 19:33 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Dave Reisner (falconindy)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
systemd-nspawn returns exit code 1 when invoked with --version or --help.

Additional info:
systemd 232-4

Steps to reproduce: Execute:

$ systemd-nspawn --version
$ echo $?
1

The above behavior breaks https://www.archlinux.org/packages/community/x86_64/rkt/ as reported in https://github.com/coreos/rkt/issues/3431.

The attached diff to systemd's PKGBUILD fixes nspawn's behavior. It was fixed upstream in https://github.com/systemd/systemd/commit/cfed63f60dd7412c199652825ed172c319b02b3c and thus can easily backported.
   PKGBUILD.patch (0.6 KiB)
This task depends upon

Closed by  Dave Reisner (falconindy)
Friday, 09 December 2016, 19:33 GMT
Reason for closing:  Fixed
Additional comments about closing:  systemd-232-5
Comment by Massimiliano Torromeo (mtorromeo) - Friday, 02 December 2016, 15:04 GMT
Sergiusz, who is part of the rkt team, contacted me about this issue and the backport of the patch seems to be the ideal solution.

Given that we just recently released v232 in [core] it would probably take too long to have a fix available if we had to wait for v233.
Comment by Sergiusz Urbaniak (sur) - Friday, 02 December 2016, 15:12 GMT
Just as a side note, debian sid has this patch applied too, see https://sources.debian.net/src/systemd/232-7/debian/patches/nspawn-fix-exit-code-for-help-and-version-4609.patch/.
Comment by Dave Reisner (falconindy) - Friday, 02 December 2016, 15:20 GMT
That's the same patch as the upstream commit...
Comment by Massimiliano Torromeo (mtorromeo) - Tuesday, 06 December 2016, 07:51 GMT
@Dave: What Sergiusz meant is that Debian has already applied the same upstream fix that he is suggesting we should apply here.
Comment by Dave Reisner (falconindy) - Wednesday, 07 December 2016, 19:49 GMT
Should be fixed in systemd-232-5.

Loading...