FS#52014 - [reflector] Please remove 'completion_pct' check!

Attached to Project: Community Packages
Opened by 謝致邦 (Red54) - Thursday, 01 December 2016, 09:56 GMT
Last edited by Xyne (Xyne) - Saturday, 03 December 2016, 20:46 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Xyne (Xyne)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

/usr/lib/python3.5/site-packages/Reflector.py:
189: # Filter incomplete mirrors and mirrors that haven't synced.
190: mirrors = list(m for m in mirrors if m['last_sync'] and m['completion_pct'] == 1.0)

According to https://www.archlinux.org/mirrors/status/

The 'completion_pct' is :
The number of mirror checks that have successfully connected and disconnected from the given URL. If this is below 100%, the mirror may be unreliable.

If 'completion_pct' != 1.0, it just shows the mirror is not 100% that the archlinux mirror check server can connect to it, and has nothing business to show whether it has synced, and also has nothing business to show whether the mirror is 100% that the users in the country of the mirror can connected to it because the archlinux mirror check server it not in that country!
This task depends upon

Closed by  Xyne (Xyne)
Saturday, 03 December 2016, 20:46 GMT
Reason for closing:  Fixed
Additional comments about closing:  The upstream dev is awesome.
Comment by Xyne (Xyne) - Saturday, 03 December 2016, 20:45 GMT
I have added a filter option: --completion-percent. Use it to select the minimum completion percent. The default is 100 (i.e. same behavior as before).

Loading...