FS#51968 - Atom feed of package repo have non-escaped href
Attached to Project:
AUR web interface
Opened by Jordan Galby (Gravemind2a) - Saturday, 26 November 2016, 17:53 GMT
Last edited by Lukas Fleischer (lfleischer) - Thursday, 23 April 2020, 00:19 GMT
Opened by Jordan Galby (Gravemind2a) - Saturday, 26 November 2016, 17:53 GMT
Last edited by Lukas Fleischer (lfleischer) - Thursday, 23 April 2020, 00:19 GMT
|
Details
Atom feeds from package repo contain un-escaped character in
link's href, making firefox (45.5) and other feed aggregator
fail.
Example: [1], first occurrence at line 12, href link contains an "&", and should have been "&" I looked at cgit atom feed generator source code, but it seems to escape the url properly. And, looking at the un-escaped url [2], the '&h=pacaur' at the end does not seem to come from cgit (official source code), so, I was just wondering if aurweb did something there ?! [1] https://aur.archlinux.org/cgit/aur.git/atom/?h=pacaur [2] https://aur.archlinux.org/cgit/aur.git/commit/?id=3bc75b9629815f0dffe7d9da644b871b79a06e09&h=pacaur |
This task depends upon
Closed by Lukas Fleischer (lfleischer)
Thursday, 23 April 2020, 00:19 GMT
Reason for closing: Not a bug
Thursday, 23 April 2020, 00:19 GMT
Reason for closing: Not a bug
I've asked CGIT guys to help: https://lists.zx2c4.com/pipermail/cgit/2017-January/003454.html
But I think _here_ [1], this is not the issue: the commit url is `?id=sha1` (not `&id=sha1`), so nothing to escape _here_.
And then that's where I get confused: I cannot find where the non-escaped `..&h=pacaur` is appended.
[1] https://aur.archlinux.org/cgit/aur.git/commit/?id=3bc75b9629815f0dffe7d9da644b871b79a06e09&h=pacaur
There is a patch[1] for this issue, but I have not got time to verify it.
[1] https://lists.zx2c4.com/pipermail/cgit/2017-January/003454.html