FS#51845 - [python-cysignals] python-cysignals should not depend on pari-sage, and suggested fix for PKGBUILD

Attached to Project: Community Packages
Opened by Antony Lee (anntzer) - Tuesday, 15 November 2016, 23:28 GMT
Last edited by Antonio Rojas (arojas) - Wednesday, 16 November 2016, 07:06 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
As far as I can see, python-cysignals does not depend on pari-sage: there's no mention of such dependency in the docs, and I've successfully used it (in my earlier AUR version) without pari-sage.

Additionally, instead of hardcoding

# Fix include dir
sed -e "s|/build/cysignals/pkg/$pkgname||" -i "$pkgdir"/usr/lib/*/site-packages/cysignals/__init__.pxd

in package(), it is possible to directly generate files with the correct path by going via a wheel:

build() {
cd $srcdir/$_pyname-$pkgver
# This allows sets the correct path in `cysignals/__init__.pxd`.
PIP_CONFIG_FILE=/dev/null pip --isolated wheel --no-deps .
}

package() {
cd $srcdir/$_pyname-$pkgver
PIP_CONFIG_FILE=/dev/null pip --isolated \
install --root="$pkgdir" --ignore-installed --no-deps *.whl
}

Additional info:
python-cysignals 1.3.2-1
This task depends upon

Closed by  Antonio Rojas (arojas)
Wednesday, 16 November 2016, 07:06 GMT
Reason for closing:  Not a bug
Comment by Antonio Rojas (arojas) - Wednesday, 16 November 2016, 07:05 GMT
Sure you *can* build it without pari, but if you build with it it becomes a hard dependency.
As for the build path: thanks for the notice. This is really an upstream issue which I hope will get fixed in a future release, so I'd rather not complicate the packaging too much. In 1.3.2-2 I'm using a glob to avoid hardcoding the path.

In the future please use one ticket per issue, otherwise it's hard to keep track of them.

Loading...