FS#51666 - [lib32-gnutls] Consistent libidn usage

Attached to Project: Community Packages
Opened by userwithuid (userwithuid) - Thursday, 03 November 2016, 06:48 GMT
Last edited by Toolybird (Toolybird) - Tuesday, 04 April 2023, 01:29 GMT
Task Type Bug Report
Category Packages: Multilib
Status Closed
Assigned To Felix Yan (felixonmars)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

gnutls in [core] uses --without-libidn . lib32-gnutls does not use this switch so libidn usage is enabled by default.

Looking through the the history of both packages, libidn was enabled and disabled a couple of times. Most recently, core-gnutls enabled it for 1 commit between 3.4.2 and 3.4.3 that had no package release [1], then disabled again for 3.4.3-1 [2] for security-related reasons (no idea if they are still relevant). Most recently, lib32-gnutls enabled it for 3.4.3-1 [3] and never disabled it since then.

I think both packages should use the same settings, but I don't know if on or off is the right choice. (I filed for this package because it's probably a easier to just follow [core] :-) ).

Sidenote: libidn was also just disabled in curl 7.51.0 [4], which made me look into other dependent packages and find this.


[1] https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/gnutls&id=c08d644de587b71e17d0761b4fb3b28c39e4fa98
[2] https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/gnutls&id=879905f953d581b9b781acd4d6acd07a850a6d79
[3] https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/lib32-gnutls&id=cedd11795cf8472438ed4a201586a6fbb37cb973
[4] https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/curl&id=3c3158856e31757662a9000afb6e576041392a9a
This task depends upon

Closed by  Toolybird (Toolybird)
Tuesday, 04 April 2023, 01:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  See comments
Comment by Emil (xexaxo) - Friday, 07 February 2020, 13:04 GMT
Humble poke

Can we sync the lib32-gnutls package with it's gnutls brethren to use [lib32-]libidn2?
This should resolve the inline comment and ensure we're using analogous codepaths for 32 and 64bit applications.

Added bonus, the lib32-gnutls <> gnutls delta will be smaller essentially making the maintenance easier.
Comment by Emil (xexaxo) - Saturday, 28 November 2020, 13:35 GMT
Humble ping?

I can prepare a patch if the maintainer prefer.
Comment by Emil (xexaxo) - Sunday, 29 November 2020, 00:39 GMT
Actually the libidn -> libidn2 was addressed with in 3.6.14.

The PKGBUILD could use some cleanup though - the "disable libidn for security reasons" amongst others is still there.
Comment by Toolybird (Toolybird) - Tuesday, 04 April 2023, 01:28 GMT
Orphaned pkg. Still a bit untidy...but original bug is fixed.

Loading...