FS#51567 - [hexchat] Wants extra/iso-codes as dependency

Attached to Project: Community Packages
Opened by Matthias Lisin (matthias.lisin) - Friday, 28 October 2016, 14:07 GMT
Last edited by Maxime Gauduin (Alucryd) - Sunday, 30 October 2016, 14:36 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Maxime Gauduin (Alucryd)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
This report is about whether extra/iso-codes should be a dependency of community/hexchat.
Right now iso-codes is (only) a make-dependency.

This happens only when iso-codes is NOT installed.
When starting hexchat and connecting to a server the program outputs the following warnings:

---

** (hexchat:3046): WARNING **: iso_639.xml: Failed to open file '/usr/share/xml/iso-codes/iso_639.xml': open() failed: No such file or directory

** (hexchat:3046): WARNING **: iso_3166.xml: Failed to open file '/usr/share/xml/iso-codes/iso_3166.xml': open() failed: No such file or directory

---

Hexchat keeps working. Only the warnings aer emitted.

extra/iso-codes should be a dependency or at least an optional dependency. (IMO)


Steps to reproduce:

0. Uninstall iso-codes
1. Start HexChat (preferably from a terminal to see the Warnings)
2. Connect to a (random) server
3. Look at the programm output. You should see the WARNING messages from above.
This task depends upon

Closed by  Maxime Gauduin (Alucryd)
Sunday, 30 October 2016, 14:36 GMT
Reason for closing:  Implemented
Additional comments about closing:  2.12.3-1
Comment by Doug Newgard (Scimmia) - Friday, 28 October 2016, 17:02 GMT
If the warnings are harmless, why does it matter?
Comment by Matthias Lisin (matthias.lisin) - Friday, 28 October 2016, 18:04 GMT
@Scimmia That's why I set the severity to "Very Low".

The program wants those files for some reason, attemps to open them and fails.
Means it depends on iso-codes to be available. And isn't this what the package manager and package dependencies are all about?
In this case and many other cases this doesn't affect the behavior of the application or at least we don't see it but in a latter version this might.

Adding the dependency will fix the warnings, avoid similar bug reports and prevent major problems like crashes in the future.

This is my opinion on this case. If you disagree, then please show me your view on this matter.
Comment by Matthias Lisin (matthias.lisin) - Friday, 28 October 2016, 22:12 GMT
Ok, after looking at the source of hexchat I found out the iso-codes XML files are only used to get the language name for iso-codes.

So basically the spell checker shows "German (Germany)" or "English (United States)" instead of de_DE, en_US (which it fallbacks to if the xml files are not available).

https://github.com/hexchat/hexchat/blob/v2.12.2/src/fe-gtk/sexy-spell-entry.c#L614

@Scimmia: You're right here. Doesn't matter in this case and is also not worth installing a 15.90 MB sizes package.
Feel free to close this report if there is nothing else to discuss.
Comment by Doug Newgard (Scimmia) - Saturday, 29 October 2016, 14:53 GMT
Thanks for looking into it. It sounds like something that could be made a optional dep if the maintainer wanted to.

Loading...