FS#51487 - [ardour] ardour.desktop information not updated to match new version rendering it non-functional.
Attached to Project:
Arch Linux
Opened by Llewelyn Trahaearn (llewelyn) - Saturday, 22 October 2016, 02:59 GMT
Last edited by Ray Rashif (schivmeister) - Friday, 17 February 2017, 14:23 GMT
Opened by Llewelyn Trahaearn (llewelyn) - Saturday, 22 October 2016, 02:59 GMT
Last edited by Ray Rashif (schivmeister) - Friday, 17 February 2017, 14:23 GMT
|
Details
Description: The information in the source .desktop file was
not updated for Ardour 5.4, leaving it pointing to locations
and files that do not exist
(https://git.archlinux.org/svntogit/packages.git/tree/trunk/ardour.desktop?h=packages/ardour).
Under GNOME this results in the icon for the app not being
displayed; however, in other environments it could result in
a non-functional icon being displayed. Utilizing gendesk to
generate the desktop file instead of relying on a static
source would probably remedy this problem indefinitely.
Additional info: ardour 5.4-1 Steps to reproduce: Install/Update the ardour 5.4-1 package. |
This task depends upon
Closed by Ray Rashif (schivmeister)
Friday, 17 February 2017, 14:23 GMT
Reason for closing: Fixed
Additional comments about closing: testing/5.6-1
Friday, 17 February 2017, 14:23 GMT
Reason for closing: Fixed
Additional comments about closing: testing/5.6-1
I took a moment to implement the suggested change, using gendesk to generate the .desktop file instead of sourcing it. The file generated is nearly identical to the existing ardour.desktop save that it works against ardour 5. The changes to the PKGBUILD are minimal and mostly constrained to prepare().
The updated PKGBUILD can be examined here: https://gist.github.com/WoefulDerelict/b2acd064e3f231f0cb10b1fe99120b73
I have attached a modified PKGBUILD based on Lleweln's Gist with a "parametrized" call to gendesk.
I'd really love to see Ardour 5.4 in community instead of community-testing in the near future!
There are certainly a number of ways to solve this particular problem and sacrificing simplicity some could even be robust. Dynamically generating or modifying the content using standard PKGBUILD variables like $pkgver as jmx suggested is a simple favourite used in many PKGBUILDs; however, it is easily defeated by changes in resource locations. This can be seen in the most recent update from Ardour 4 to 5. The icon was moved from /usr/share/ardour4/icons/ardour_icon_256px.png to /usr/share/ardour5/resources/Ardour-icon_256px.png. So long as the resource names remain predicable it would be possible to locate and dynamically insert/update this information. This could of course just as easily be done with sed and a source stub or even echo as it could with gendesk. As one was just mocking up an alternative in the most easy to read and understand fashion I'm not expressly advocating it as the solution. I'll leave the deployment details to the maintainer as continued upkeep remains their responsibility so whichever tools they are familiar with are probably best.
I have corrected one small issue in my previous "parametrized" PKGBUILD that I posted 3 weeks ago.
By the way, I have just used this PKGBUILD to build the by now released Ardour 5.5 and I edited music with this build the whole afternoon without coming across any issues. I think it's fairly safe to finally bump the Ardour version in community!
Best,
jmx