Pacman

Welcome to the Pacman bug tracker. Please search the current bugs and feature requests before filing a new one! Use advanced search and select "Search in Comments".

* Please select the correct category and version.
* Write a descriptive summary, background info, and provide a reproducible test case whenever possible.
Tasklist

FS#51481 - Pkgver linting allows values with "/" in them

Attached to Project: Pacman
Opened by mirh (mirh) - Friday, 21 October 2016, 14:27 GMT
Last edited by Allan McRae (Allan) - Saturday, 14 January 2017, 07:55 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Medium
Priority Normal
Reported Version 5.0.1
Due in Version 5.1.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The poorly formed pkgver function in the example below can give pkgver the value "heads/makepkg". lint_pkgver should not allow that.


**Original summary**
Summary and Info:
If pkgver() function returns a malformed string, this leaks into commands line.

Steps to Reproduce:
1. Download f2fs-tools-git PKGBUILD https://aur.archlinux.org/packages/f2fs-tools-git
2. Specify #branch=dev
3. Run makepkg
This task depends upon

Closed by  Allan McRae (Allan)
Saturday, 14 January 2017, 07:55 GMT
Reason for closing:  Fixed
Additional comments about closing:  git commit 5dfa3c8f
Comment by Allan McRae (Allan) - Saturday, 22 October 2016, 00:53 GMT
It is not leaking anywhere...

The pkgver() function on the dev branch gives:

pkgver=heads/makepkg

This is a bad pkgver... The real bug here is that this passes our pkgver validity check.
Comment by Steef Hegeman (Steef435) - Sunday, 23 October 2016, 00:39 GMT
Is a patch like this what you're looking for?
Comment by Allan McRae (Allan) - Sunday, 23 October 2016, 00:41 GMT
Exactly what is needed. Thanks.

Loading...