FS#51481 - Pkgver linting allows values with "/" in them
Attached to Project:
Pacman
Opened by mirh (mirh) - Friday, 21 October 2016, 14:27 GMT
Last edited by Allan McRae (Allan) - Saturday, 14 January 2017, 07:55 GMT
Opened by mirh (mirh) - Friday, 21 October 2016, 14:27 GMT
Last edited by Allan McRae (Allan) - Saturday, 14 January 2017, 07:55 GMT
|
Details
The poorly formed pkgver function in the example below can
give pkgver the value "heads/makepkg". lint_pkgver should
not allow that.
**Original summary** Summary and Info: If pkgver() function returns a malformed string, this leaks into commands line. Steps to Reproduce: 1. Download f2fs-tools-git PKGBUILD https://aur.archlinux.org/packages/f2fs-tools-git 2. Specify #branch=dev 3. Run makepkg |
This task depends upon
Closed by Allan McRae (Allan)
Saturday, 14 January 2017, 07:55 GMT
Reason for closing: Fixed
Additional comments about closing: git commit 5dfa3c8f
Saturday, 14 January 2017, 07:55 GMT
Reason for closing: Fixed
Additional comments about closing: git commit 5dfa3c8f
The pkgver() function on the dev branch gives:
pkgver=heads/makepkg
This is a bad pkgver... The real bug here is that this passes our pkgver validity check.