FS#5138 - mkinitcpio 0.4.3-1: disablemodules does not work

Attached to Project: Arch Linux
Opened by Greg Schulein (gschulein) - Monday, 31 July 2006, 17:24 GMT
Last edited by Tobias Powalowski (tpowa) - Monday, 31 July 2006, 20:59 GMT
Task Type Bug Report
Category Packages: Current
Status Closed
Assigned To Aaron Griffin (phrakture)
Architecture not specified
Severity Low
Priority Normal
Reported Version 0.7.2 Gimmick
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Package: mkinitcpio 0.4.3-1
File: /lib/initcpio/init

There appears to be a typo that prevents the disablemodules option from working.
Line 46:
eval "TST=\$mod_${h}"
should be:
eval "TST=\$mod_${m}"

If you care, there is also a spelling error in the comment on line 73 (is --> if)

Also, is the comment on line 80 out of place?
This task depends upon

Closed by  Aaron Griffin (phrakture)
Tuesday, 01 August 2006, 02:09 GMT
Reason for closing:  Implemented
Additional comments about closing:  mkinitcpio 0.4.4
Comment by Aaron Griffin (phrakture) - Monday, 31 July 2006, 21:35 GMT
There is that, but an additional issue with disable_modules is that load-modules.sh with the normal udev package needs to honor this as well. i have made a handful of local changes to load-modules.sh in an attempt to speed things up when loading modules, and also added the disable_module kernel param handling. I've been oddly busy recently, but will attempt to get this stuff done tonight.

Loading...