FS#51257 - [squid] Do not start squid-rotate.timer statically

Attached to Project: Community Packages
Opened by Jonas Hahnfeld (hahnjo) - Thursday, 06 October 2016, 15:12 GMT
Last edited by Sergej Pupykin (sergej) - Monday, 19 December 2016, 14:48 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
squid-rotate.timer is currently enabled by a symlink in /usr/lib/systemd/system/timers.target.wants/ and $ systemctl disable squid-rotate.timer does not work.
This is bad when squid does not run by default because the corresponding unit will then fail each time executed.
Instead I think it should be enabled in the .install file so that the user can choose to disable the timer.

Additional info:
* squid 3.5.21-1
This task depends upon

Closed by  Sergej Pupykin (sergej)
Monday, 19 December 2016, 14:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  added [install] section and fixed install messages.
Comment by Daniel M. Capella (polyzen) - Thursday, 06 October 2016, 21:25 GMT
<MacGyver> polyzen: Looks to me like the timer should be contingent on the enabling of squid itself.
Comment by Jonas Hahnfeld (hahnjo) - Monday, 19 December 2016, 01:46 GMT
  • Field changed: Percent Complete (100% → 0%)
This does not look right in 3.5.23-1:
The unit files have no installation config (WantedBy, RequiredBy, Also, Alias settings in the [Install] section, and DefaultInstance for template units).

It is probably missing the following section:
[Install]
WantedBy=timers.target

Additionally, I think that it shouldn't print out the message "- squid-rotate.timer is not enabled by default" on every install but rather only on an upgrade from 3.5.22-1

Loading...