FS#50378 - [gitlab] Assets need to be in /var

Attached to Project: Arch Linux
Opened by Tobias Hunger (hunger) - Saturday, 13 August 2016, 03:15 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Monday, 29 August 2016, 22:57 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Assets need to be in /var/lib/gitlab, not in /usr.

Additional info:
* 8.10.4-2

Steps to reproduce:
* Upgrade gitlab
* Try to upgrade the assets

Expected Result:
* Assets are updated

Actual Result:
* Access to assets is denied since /usr is read-only.

This can be fixed by moving /usr/share/webapps/gitlab/public/assets to /var/lib/gitlab/assets and then creating a symlink.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Monday, 29 August 2016, 22:57 GMT
Reason for closing:  Not a bug
Comment by Doug Newgard (Scimmia) - Saturday, 13 August 2016, 05:15 GMT
And why is /usr read only?
Comment by Doug Newgard (Scimmia) - Monday, 15 August 2016, 05:20 GMT
Ping?
Comment by Tobias Hunger (hunger) - Monday, 15 August 2016, 06:28 GMT
The gitlab unit files do ProtectSystem=full, so for gitlab /usr is read-only by default.

In addition to that: I also see no reason for a web-accessible piece of software to be able to write files in /usr. In fact nothing but a package manager should ever write into /usr *ever*. So I mount /usr from a read-only btrfs snapshot. But that is a personal setup issue:)
Comment by Sven-Hendrik Haase (Svenstaro) - Friday, 26 August 2016, 22:17 GMT
The assets are made during installation and pre-generated. This hasn't been a problem in our production installation. What leads you to wanting to regenerate those?
Comment by Tobias Hunger (hunger) - Sunday, 28 August 2016, 12:31 GMT
You might be right.

I grabbed a script to update my gitlab installations and that includes an update of the assets. That might actually be unnecessary with the package...

Need to test that:)
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 29 August 2016, 22:57 GMT
Closing for now. Gitlab works perfectly for me out-of-the-box as I designed it to be in the package.

Loading...