FS#50071 - [lz4] version string incorrect (lz4 --version)

Attached to Project: Arch Linux
Opened by Ido Rosen (idorosen) - Saturday, 16 July 2016, 15:13 GMT
Last edited by Sébastien Luttringer (seblu) - Saturday, 20 August 2016, 01:17 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The installed LZ4 is r131, but the --version output shows r128. This is an upstream bug that was fixed in the dev branch on the github repository, but lz4 has not had a version released in over a year, including many bug fixes since r131. We should at least fix this version printing bug downstream.

Steps to reproduce:

Type "lz4 --version" or any lz4 command that would output the version string:

$ lz4 --version
*** LZ4 command line interface 64-bits r128, by Yann Collet (Jun 30 2015) ***
$ pacman -Q lz4
lz4 131-1
This task depends upon

Closed by  Sébastien Luttringer (seblu)
Saturday, 20 August 2016, 01:17 GMT
Reason for closing:  Fixed
Additional comments about closing:  lz4-131-2
Comment by Sébastien Luttringer (seblu) - Thursday, 18 August 2016, 00:32 GMT
Did you try to request a release upstream? There is a lot of patches since the last release.

Do you have a patch or the commit which fix the bug you mention?
Comment by Ido Rosen (idorosen) - Thursday, 18 August 2016, 00:53 GMT
Building it manually shows the correct version currently, based on the r131 tag:

git clone git@github.com:Cyan4973/lz4 -b r131
cd lz4
make
programs/lz4 --version
Comment by Ido Rosen (idorosen) - Thursday, 18 August 2016, 00:53 GMT
But the packaged version does not.
Comment by Sébastien Luttringer (seblu) - Saturday, 20 August 2016, 01:00 GMT
the main makefile is broken. when makepkg export CFLAGS it's overrides LZ4_VERSION because it calls make -e

Loading...