Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
FS#49955 - [st] config.h changes don't take effect
Attached to Project:
Community Packages
Opened by Will Alexander (willalexander) - Tuesday, 05 July 2016, 09:14 GMT
Last edited by Doug Newgard (Scimmia) - Wednesday, 06 July 2016, 06:25 GMT
Opened by Will Alexander (willalexander) - Tuesday, 05 July 2016, 09:14 GMT
Last edited by Doug Newgard (Scimmia) - Wednesday, 06 July 2016, 06:25 GMT
|
DetailsDescription:
The st package doesn't copy config.h correctly when building the package, meaning no changes to the file take effect. Additional info: Bug occurs with st 0.6-3. Here is a PKGBUILD which copies config.h correctly in prepare(): pkgname=st pkgver=0.6 pkgrel=4 pkgdesc='A simple virtual terminal emulator for X.' arch=('i686' 'x86_64') license=('MIT') depends=('libxft' 'libxext' 'xorg-fonts-misc') makedepends=('ncurses') url="http://st.suckless.org" source=(http://dl.suckless.org/st/$pkgname-$pkgver.tar.gz config.h) md5sums=('1a926f450b4eacb7e2f5ac5b8ffea7c8' '06f5d56f754a918916d6c92df75e6d11') prepare() { cd $srcdir/$pkgname-$pkgver # skip terminfo which conflicts with nsurses sed -i '/\@tic /d' Makefile cp $srcdir/config.h config.h } build() { cd $srcdir/$pkgname-$pkgver cp $srcdir/config.h config.h make X11INC=/usr/include/X11 X11LIB=/usr/lib/X11 } package() { cd $srcdir/$pkgname-$pkgver make PREFIX=/usr DESTDIR="$pkgdir" TERMINFO="$pkgdir/usr/share/terminfo" install install -Dm644 LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE" install -Dm644 README "$pkgdir/usr/share/doc/$pkgname/README" } Steps to reproduce: 1. Fetch community/st using abs 2. Build and install st with e.g. makepkg -si 3. Modify config.h 4. Rebuild and reinstall st with e.g. makepkg -efi |
This task depends upon
Comment by Doug Newgard (Scimmia) -
Tuesday, 05 July 2016, 13:45 GMT
I don't see the issue. The file is already (correctly) copied in the prepare function.
Comment by Will Alexander (willalexander) -
Wednesday, 06 July 2016, 05:30 GMT
My mistake -- the missing copy is in build() (the second line of the function in my example PKGBUILD).
Comment by Doug Newgard (Scimmia) -
Wednesday, 06 July 2016, 06:25 GMT
Which is not necessary, it's already correctly copied in the prepare function. You're just editing the wrong file at the wrong time.