FS#49624 - [zlib,minizip] can zlib include minizip
Attached to Project:
Arch Linux
Opened by Florian Bruhin (The-Compiler) - Wednesday, 08 June 2016, 15:48 GMT
Last edited by Pierre Schmitz (Pierre) - Saturday, 03 December 2016, 08:53 GMT
Opened by Florian Bruhin (The-Compiler) - Wednesday, 08 June 2016, 15:48 GMT
Last edited by Pierre Schmitz (Pierre) - Saturday, 03 December 2016, 08:53 GMT
|
Details
It seems Arch switched from the upstream minizip to some
GitHub fork with epoch 1:
https://git.archlinux.org/svntogit/community.git/commit/trunk/PKGBUILD?h=packages/minizip&id=d95c6b6488e0a6f27165902fe48c1e4ba1ddfa55 However, that is incompatible with the upstream minizip: https://github.com/nmoinvaz/minizip/commit/50665d2d596ab2f0ac132c99f01354112a63e837 https://github.com/nmoinvaz/minizip/blob/master/ChangeLog The "Clean up & changed unzLocateFile to support custom comparison function" change changed the signature of unzLocateFile: -extern int ZEXPORT unzLocateFile OF((unzFile file, - const char *szFileName, - int iCaseSensitivity)); +extern int ZEXPORT unzLocateFile OF((unzFile file, const char *filename, unzFileNameComparer filename_compare_func)); This means packages which depend on minizip, such as qt5-webengine, no longer build successfully: https://bugreports.qt.io/browse/QTBUG-53933 I think this package should be reverted to the upstream one, and perhaps the fork packaged as a separate thing. Not sure what else broke in that monster "cleanup" commit either... |
This task depends upon
Closed by Pierre Schmitz (Pierre)
Saturday, 03 December 2016, 08:53 GMT
Reason for closing: Implemented
Saturday, 03 December 2016, 08:53 GMT
Reason for closing: Implemented
Pierre, could minizip from the zlib tarball be included in the zlib package, so that this minizip package can be moved to AUR instead (or be removed)?
2016-06-09 09:14:07 <arojas> The-Compiler: i switched to internal minizip for 5.7