Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#49553 - [gitlab-shell] authorized_keys not updated when adding new SSH key

Attached to Project: Community Packages
Opened by Melvin Vermeeren (melvinvermeeren) - Friday, 03 June 2016, 07:44 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 11 June 2016, 20:14 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
/etc/webapps/gitlab-shell/authorized_keys is not updated when adding a SSH key through the web interface.

Additional info:
local/gitlab 8.8.2-4
Project management and code hosting application
local/gitlab-ci-multi-runner 1.2.0-1
The official GitLab CI runner written in Go
local/gitlab-shell 2.7.2-13
Self hosted Git management software. Replacement for gitolite
local/gitlab-workhorse 0.7.2-6
HTTP server to unload Git HTTP traffic from GitLab Rails app (Unicorn)

Steps to reproduce:
1. Add SSH key through profile settings.
2. Key not added to authorized_keys (and therefore permission denied).

Note that the key is successfully added to the database, it is only not added to the authorized_keys file.

Interestingly, when I restored a backup after doing a 100% clean install after the AUR -> community changes it did generate a proper authorized_keys file, it's just not updating.

I've had this issue since the switch from AUR, but I assumed the clean install had fixed it until a user added a new key today.


Unfortunately, the logs are absolutely useless in this case.
The exact same "Adding key key-${ID} => "ssh-rsa ...${KEY}..." is shown both during the backup restore and adding new keys. Even though the latter doesn't work properly.

The workaround is manually adding the key to the authorized_keys file, based upon ID which can be obtained from admin interface key management URL.


I did some searching and can't find the cause myself, I'm hoping others have the issue or can perhaps help solving it.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Saturday, 11 June 2016, 20:14 GMT
Reason for closing:  Fixed
Comment by Jarryd Beck (jarro_2783) - Tuesday, 07 June 2016, 23:52 GMT
I can confirm this. It also seemed to happen in the change from the AUR. I have reported it to gitlab but no one has replied so far either.
Comment by Sven-Hendrik Haase (Svenstaro) - Saturday, 11 June 2016, 20:14 GMT
Fixed, it may not be a symlink.

Loading...