FS#49489 - {namcap} should not warn on ELF files installed to /opt

Attached to Project: Arch Linux
Opened by Antony Lee (anntzer) - Saturday, 28 May 2016, 00:56 GMT
Last edited by Kyle Keen (keenerd) - Thursday, 22 February 2018, 23:15 GMT
Task Type Bug Report
Category Arch Projects
Status Closed
Assigned To Kyle Keen (keenerd)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 5
Private No

Details

namcap 3.2.7 warns (at Error level) on ELF files installed to /opt, but it probably shouldn't, as dumping large, self-contained packages in /opt is standard (and suggested in the wiki: https://wiki.archlinux.org/index.php/Arch_packaging_standards)

Steps to reproduce:
Build the google-talkplugin package from AUR and run namcap on it. namcap reports:

google-talkplugin E: ELF file ('opt/google/talkplugin/GoogleTalkPlugin') outside of a valid path.
google-talkplugin E: ELF file ('opt/google/talkplugin/libgoogletalkremoting.so') outside of a valid path.
google-talkplugin E: ELF file ('opt/google/talkplugin/libnpgoogletalk.so') outside of a valid path.
google-talkplugin E: ELF file ('opt/google/talkplugin/libnpo1d.so') outside of a valid path.
google-talkplugin E: ELF file ('opt/google/talkplugin/libppgoogletalk.so') outside of a valid path.
google-talkplugin E: ELF file ('opt/google/talkplugin/libppo1d.so') outside of a valid path.
This task depends upon

Closed by  Kyle Keen (keenerd)
Thursday, 22 February 2018, 23:15 GMT
Reason for closing:  Fixed
Additional comments about closing:  No complaints about the improvement.
Comment by Kyle Keen (keenerd) - Saturday, 28 May 2016, 01:50 GMT
This partially depends on how you feel about /opt. It really should only be used as a last resort, and you should try to get the package to fit in the standard file hierarchy.

I could see downgrading it to a warning.
Comment by Antony Lee (anntzer) - Saturday, 28 May 2016, 03:31 GMT
If dumping everything in /opt is considered last-resort, then perhaps everything could be consolidated into a single warning? Typically, I'd say there aren't that many advantages in having lines and lines of (essentially) the same warning.
Comment by Kyle Keen (keenerd) - Saturday, 10 December 2016, 08:33 GMT
Mostly improved in commit 5d23522. All errors for opt are condensed into a single error, while the full paths of every offending file can be found in the Info output.

Loading...