FS#49476 - [s3cmd] python2-magic should be an optional dependency

Attached to Project: Community Packages
Opened by Guto Andreollo (GutoAndreollo) - Thursday, 26 May 2016, 20:41 GMT
Last edited by Jelle van der Waa (jelly) - Wednesday, 01 June 2016, 19:21 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

python2-magic should be an optional dependency to s3cmd, since it's used to determine the mimetype based on contents (instead of simply the file extension).

It should NOT be listed as a dependency, since s3cmd performs all the duties (but trying to guess the mimetime based on contents) without it.

This information is provided directly by s3cmd, when performing an upload without this package installed:

WARNING: Module python-magic is not available. Guessing MIME types based on file extensions.

(note: "python-magic" is the python package name. This module is provided by the "python2-magic" Arch Package

Additional info:
* package version(s): 1.6.1-1 (latest, at the time)
* config and/or log files etc.


Steps to reproduce:

- install the s3cmd package, and take notice of the optional packages.
- note that python2-magic is absent
- try and perform a file upload to S3 with a mislabeled extension (example given was a .box Vagrant file)
- note the message provided by s3cmd, referring to the fact that since this module is unavailable, it will only take into account the file extension
- on S3 after the upload completes, note that the mimetype is wrong
This task depends upon

Closed by  Jelle van der Waa (jelly)
Wednesday, 01 June 2016, 19:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 1.6.1-2

Loading...