FS#49468 - [dkms] Restore verbose hook output
Attached to Project:
Arch Linux
Opened by Kevin Brodsky (Corax) - Wednesday, 25 May 2016, 23:42 GMT
Last edited by Doug Newgard (Scimmia) - Thursday, 26 May 2016, 02:18 GMT
Opened by Kevin Brodsky (Corax) - Wednesday, 25 May 2016, 23:42 GMT
Last edited by Doug Newgard (Scimmia) - Thursday, 26 May 2016, 02:18 GMT
|
Details
Description:
dkms 2.2.0.3+git151023-9 added "-q" to the dkms invocations in hook.sh. This had the unfortunate effect of silencing any build error, since the hook doesn't check the return code of dkms. In my case all my modules stopped building because I had to update my kernel (from the AUR), and I only realised it when I saw the modules missing after rebooting. Two solutions would be acceptable to me: 1. Remove "-q". This produces more log but I think the verbosity is quite acceptable. 2. Check the return code of dkms in both do_module() and do_kernel(), logging and propagating any error. This is more complicated (and not verbose enough to my taste) but if the quiet behaviour is really wanted, this is the way to go. Steps to reproduce: 1. Build a -dkms package so that dkms fails to build the module (introducing any compilation error would do). 2. pacman -U, observe that the post-install hook doesn't complain but your module has vanished in /usr/lib/modules/<kernel>/. |
This task depends upon
Closed by Doug Newgard (Scimmia)
Thursday, 26 May 2016, 02:18 GMT
Reason for closing: Duplicate
Additional comments about closing: FS#49080
Thursday, 26 May 2016, 02:18 GMT
Reason for closing: Duplicate
Additional comments about closing: