FS#49458 - [systemd] add_systemd_unit should check for already provisioned binaries

Attached to Project: Arch Linux
Opened by Andrei Pozolotin (random-archer) - Tuesday, 24 May 2016, 17:11 GMT
Last edited by Dave Reisner (falconindy) - Saturday, 28 May 2016, 12:52 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Thomas Bächler (brain0)
Dave Reisner (falconindy)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

1) when /etc/mkinitcpio.conf includes HOOKS="base ..."
one would expect /bin/busybox to be provisioned in the initramfs from the /usr/lib/initcpio/busybox
https://git.archlinux.org/mkinitcpio.git/tree/install/base

2) however, add_systemd_unit is looking only for host binaries
https://git.archlinux.org/svntogit/packages.git/tree/trunk/initcpio-install-systemd?h=packages/systemd#n71

3) so, when add_systemd_unit encounters stanza Exec*=/bin/busybox, it produces error
==> ERROR: file not found: `/bin/busybox'

4) therefore add_systemd_unit should check for already provisioned binaries, for example:

Exec*)
# don't add binaries unless they are required
if [[ ${values[0]:0:1} != '-' ]]; then
local exec="${values[0]}"
if [[ -f $BUILDROOT$exec ]] ; then
quiet "use existing $exec"
else
quiet "use resolved $exec"
add_binary "$exec"
fi
fi
;;
This task depends upon

Closed by  Dave Reisner (falconindy)
Saturday, 28 May 2016, 12:52 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#49460 

Loading...