FS#49421 - [libmilter] Add systemd socket activation support

Attached to Project: Arch Linux
Opened by Jonne Haß (MrZYX) - Friday, 20 May 2016, 21:31 GMT
Last edited by Gaetan Bisson (vesath) - Saturday, 21 May 2016, 22:01 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Gaetan Bisson (vesath)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

There's a patch circulating that adds systemd socket activation to libmilter by allowing to pass an fd to smfi_setconn. Please apply that patch.

The patch is already applied in major systemd based distributions like Ubuntu, Debian, Suse, Fedora. Software based on libmilter starts to make use of it, one example being rmilter.

Apparently the patch originates from https://bugzilla.suse.com/show_bug.cgi?id=879790

I have successfully applied it an locally and have a socket activated rmilter instance running based on it.
   fd-passing-libmilter.patch (2.5 KiB)
This task depends upon

Closed by  Gaetan Bisson (vesath)
Saturday, 21 May 2016, 22:01 GMT
Reason for closing:  Fixed
Additional comments about closing:  libmilter-8.15.1-2 in [extra]
Comment by Gaetan Bisson (vesath) - Saturday, 21 May 2016, 18:11 GMT
I'd really like something like this to come from upstream. Is there any chance it might find its way in an upcoming release?
Comment by Jonne Haß (MrZYX) - Saturday, 21 May 2016, 18:38 GMT
As mentioned in the linked bug report it's said to be submitted to upstream. I couldn't find anything public about it and patch submission to upstream doesn't appear to be a public ML either. https://www.sendmail.com/sm/open_source/support/contact/

Looking at https://www.sendmail.com/sm/open_source/news/ upstream doesn't seem to release too often either, so I wouldn't like to wait that long personally :)
Comment by Gaetan Bisson (vesath) - Saturday, 21 May 2016, 21:54 GMT
Well argued!
Comment by Gaetan Bisson (vesath) - Saturday, 21 May 2016, 22:01 GMT
I've pushed an updated version to [extra] though it's useless until we rebuild clamav/opendkim against it (thank you static libraries). Let me know what package (if any) you'd like to see a rebuild of by marking it as out-of-date and mentionning the libmilter bump in the comment field. Cheers.

Loading...