FS#49394 - [gtk-update-icon-cache] Broken uninstall for gnome-icon-theme-symbolic

Attached to Project: Arch Linux
Opened by Andrey Kolesnikov (definedwheel) - Thursday, 19 May 2016, 01:26 GMT
Last edited by Jan Alexander Steffens (heftig) - Thursday, 19 May 2016, 19:31 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Typo in the path for rmdir.

Steps to reproduce:
Just uninstall the package via pacman.

Additional info:
checking dependencies...

Package (1) Old Version Net Change

gnome-icon-theme-symbolic 3.12.0-4 -1.89 MiB

Total Removed Size: 1.89 MiB

:: Do you want to remove these packages? [Y/n]
:: Processing package changes...
(1/1) removing gnome-icon-theme-symbolic [----------------------] 100%
:: Running post-transaction hooks...
(1/1) Updating icon theme caches...
rmdir: failed to remove 'usr/share/icons/gnome/': No such file or directory
error: command failed to execute correctly
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Thursday, 19 May 2016, 19:31 GMT
Reason for closing:  Fixed
Additional comments about closing:  gtk3 3.20.5-1
Comment by Doug Newgard (Scimmia) - Thursday, 19 May 2016, 02:20 GMT
There is no typo, and the error is coming from a hook, not from the package remove script..
Comment by Andrey Kolesnikov (definedwheel) - Thursday, 19 May 2016, 04:08 GMT
Well, I did uninstall gnome-icon-theme before uninstalling gnome-icon-theme-symbolic.
Description is incorrect, but the bug still remains.
Comment by Jan de Groot (JGC) - Thursday, 19 May 2016, 08:09 GMT
https://git.archlinux.org/svntogit/packages.git/tree/trunk/gtk-update-icon-cache.script?h=packages/gtk3

gnome-icon-theme-symbolic doesn't come with index.theme, so the cache is not created on install if gnome-icon-theme isn't installed.
On removal, pacman deletes the /usr/share/icons/gnome directory, so when the hook wants to remove that directory it's already removed. As rmdir doesn't have an option to fail silently without adding >/dev/null redirections and || true constructions, we should fix the hook to check if the directory exists before removing it.

Loading...