FS#49332 - [gitlab-shell] Redis connection in config should be changed

Attached to Project: Community Packages
Opened by Jonas Heinrich (onny) - Saturday, 14 May 2016, 17:19 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Friday, 27 May 2016, 13:58 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
The Redis server in ArchLinux doesn't provide a socket file in its default configuration and therefore gitlab-shell should prefere the tcp connection.

In /etc/webapps/gitlab-shell/config.yml:

redis:
bin: /usr/bin/redis-cli
host: 127.0.0.1
port: 6379
# pass: redispass # Allows you to specify the password for Redis
database: 0
#socket: /var/run/redis/redis.sock # Comment out this line if you want to use TCP
namespace: resque:gitlab

"socket" should be commented out and the "host"/"port" config used!

Thank you and best regards,
Jonas
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Friday, 27 May 2016, 13:58 GMT
Reason for closing:  Implemented
Comment by Sven-Hendrik Haase (Svenstaro) - Friday, 27 May 2016, 13:51 GMT
I'm kind of torn here. Probably it would make gitlab configuration a bit easier, on the other hand it will provide an opinionated config which is not something that packages should do usually. In this case, I think I'll make an exception to that for sake of ease of configuration.

Loading...