FS#49066 - gtk-update-icon-cache in firewalld.install is unconditionally executed but is an optional dependency

Attached to Project: Community Packages
Opened by Alexandre de Verteuil (a_neutrino) - Sunday, 24 April 2016, 04:42 GMT
Last edited by Doug Newgard (Scimmia) - Sunday, 24 April 2016, 14:18 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

When installing or uninstalling firewalld on a system without gtk3, an error message from the firewalld.install script is printed complaining about the program gtk-update-icon-cache not being found.

gtk3 is listed as an optional dependency of firewalld, and gtk-update-icon-cache is required by gtk3. In firewalld.install the program gtk-update-icon-cache is executed regardless of whether the gtk-update-icon-cache package is installed or not, causing an error message on installation and uninstallation of the firewalld package.

This does not prevent the package from being installed or uninstalled. The error should simply be avoided by checking the presence of the optional dependency first.


Additional info:
* pkgver=0.4.0
* pkgrel=1


Steps to reproduce:
Install firewalld on a system without gtk3 installed, like a headless server.


Sample output:
/tmp/alpm_BoqVTn/.INSTALL: line 3: gtk-update-icon-cache: command not found


Suggested modification:
[ -e /usr/bin/gtk-update-icon-cache ] && gtk-update-icon-cache
This task depends upon

Closed by  Doug Newgard (Scimmia)
Sunday, 24 April 2016, 14:18 GMT
Reason for closing:  Deferred
Additional comments about closing:  This is going away very soon anyway

Loading...