FS#48885 - [fail2ban] Package installation script overwrites customised /etc/logrotate.d/fail2ban file

Attached to Project: Community Packages
Opened by Scott Marshall (El-Scotto) - Monday, 11 April 2016, 06:45 GMT
Last edited by Felix Yan (felixonmars) - Monday, 11 April 2016, 14:04 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The fail2ban PKGBUILD file does not preserve (backup) /etc/logrotate.d/fail2ban.
It always overwrites it with the sample file "files/fail2ban-logrotate"
(cf lines 40 and 40 of PKGBUILD)
https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/fail2ban

Additional info:
* package version(s): fail2ban-0.9.4 (and previous version)
* config and/or log files etc.: PKGBUILD configuration script.


Steps to reproduce:
* modify /etc/logrotate.d/fail2ban in any fashion.
* update (or reinstall) fail2ban
* examine /etc/logrotate.d/fail2ban and observe that your customisations have been overwritten (and not preserved)

Expected actions:
* the PKGBUILD control script should only install "files/fail2ban-logrotate" into "/etc/logrotate.d/fail2ban" IF (and ONLY IF) the file does not currently exist, otherwise it should leave it alone.
This task depends upon

Closed by  Felix Yan (felixonmars)
Monday, 11 April 2016, 14:04 GMT
Reason for closing:  Fixed
Additional comments about closing:  Added to backup array in 0.9.4-2

Loading...