FS#48801 - [hydrogen] Hardcoded icon in hydrogen.desktop

Attached to Project: Community Packages
Opened by Ismael (ChuckDaniels) - Sunday, 03 April 2016, 19:23 GMT
Last edited by David Runge (dvzrv) - Sunday, 11 March 2018, 11:41 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ray Rashif (schivmeister)
David Runge (dvzrv)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Icon has been hardcoded in the archlinux package. Original hydrogen.desktop is not hardcoded.

Additional info:
I don't understand why has been hardcoded this way but I've found these lines in the PKGBUILD:

> # TODO: tell upstream to comply with freedesktop.org icon conventions
> sed -i 's:Icon=h2-icon:Icon=/usr/share/hydrogen/data/img/gray/h2-icon.svg:' \
> "$pkgdir/usr/share/applications/$pkgname.desktop"
This task depends upon

Closed by  David Runge (dvzrv)
Sunday, 11 March 2018, 11:41 GMT
Reason for closing:  Upstream
Additional comments about closing:  Supplementary fix in 0.9.7-2
Comment by Doug Newgard (Scimmia) - Sunday, 03 April 2016, 19:36 GMT
A better fix would be to manually install the icons into the hicolor icon theme. This works as-is, though.
Comment by James Crompton (DonJaime) - Saturday, 10 March 2018, 10:38 GMT
Version 0.9.7-1

This should be increased in severity, since it has led to the icon disappearing. The Desktop file currently contains

Icon=/usr/share/hydrogen/data/img/gray/h2-icon.svg.svg

Shouldn't be too much trouble to make the arch package comply with freedesktop.org icon conventions by installing the icons in the right place. An added advantage would be that the PKGBUILD would break if upstream moved them without warning, as seems to have happened here.
Comment by David Runge (dvzrv) - Sunday, 11 March 2018, 11:31 GMT
@DonJaime: hydrogen is sadly quite a patch monster atm (hoping for 1.0 to better this). One of the patches introduced what you currently see.
I created an upstream bug for this problem [1] (this should've been done two years ago!) and fixed this for now by also installing the svg to the hicolor icon theme directory and changing the patch file.

[1] https://github.com/hydrogen-music/hydrogen/issues/558

Loading...