FS#48755 - [pcmanfm-qt] Package should depend on desktop-file-utils

Attached to Project: Community Packages
Opened by Peter Mattern (krabat) - Wednesday, 30 March 2016, 15:32 GMT
Last edited by Balló György (City-busz) - Wednesday, 15 February 2017, 23:30 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jerome Leclanche (Adys)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Package pcmanfm-qt comes with an install script running binary update-desktop-database and should hence depend on package desktop-file-utils.
This task depends upon

Closed by  Balló György (City-busz)
Wednesday, 15 February 2017, 23:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  in trunk
Comment by Doug Newgard (Scimmia) - Wednesday, 30 March 2016, 16:08 GMT
Eh, this will end up being moot in a few weeks when we switch to hooks and that install file is removed.
Comment by Peter Mattern (krabat) - Wednesday, 30 March 2016, 22:14 GMT
The install script itself will probably be removed but how about the dependency discussed here?

Definite information which packages will provide the hooks and which other packages will eventually depend on those packages doesn't seem to be available yet.
But looking at dkms which is implementing hooks already I'd expect a hook like https://github.com/andrewgregory/pachooks/blob/master/hooks/update-desktop-database.hook to be provided by package desktop-file-utils. But if so packages which want to run update-desktop-database will still have to depend on desktop-file-utils as this package will hardly ever be installed by default on every system.
Comment by Doug Newgard (Scimmia) - Wednesday, 30 March 2016, 23:17 GMT
Right, and which packages will want to run update-desktop-database? The vast majority of packages that provide desktop files don't really care about the desktop file mime database. IMO, only packages that use the database would need to depend on desktop-file-utils.

Now, being a file manager, this package may very well use that database. I don't know. Do you?
Comment by Peter Mattern (krabat) - Thursday, 31 March 2016, 11:00 GMT
PCManFM-Qt does make use of that MIME database. (It would have been pretty stupid to open this issue otherwise, wouldn't it?)
We've got
> $ grep -i mime /usr/share/applications/pcmanfm-qt.desktop
> MimeType=inode/directory;
which yields something like
> $ grep pcman /usr/share/applications/mimeinfo.cache
> inode/directory=doublecmd.desktop;qtfm.desktop;audacious.desktop;pcmanfm-qt.desktop;
after running update-desktop-database.
Comment by Jerome Leclanche (Adys) - Thursday, 31 March 2016, 11:11 GMT
I agree with Doug, this will be moot soon enough.
Comment by Doug Newgard (Scimmia) - Thursday, 31 March 2016, 15:27 GMT
krabat, that has nothing at all to do with what I said.
Comment by Peter Mattern (krabat) - Thursday, 31 March 2016, 16:20 GMT
@Scimmia
Don't know what's your idea of "use the database" then.
But the purpose of update-desktop-database is transforming values of key "MimeType" in desktop entry files into entries in mimecache.info, see man (1) update-desktop-database. So my previous comment does depict why it makes sense if pcmanfm-qt belongs to the "packages which want to run update-desktop-database".
Comment by Doug Newgard (Scimmia) - Thursday, 31 March 2016, 16:33 GMT
And who cares if the entry is in mimeinfo.cache?
Comment by Peter Mattern (krabat) - Thursday, 31 March 2016, 17:58 GMT
E. g. Chromium with regards to its options "Show in folder" or "Open downloads folder".

Btw. you do realize that e. g. Dolphin, Nautilus and PCManFM all set MimeType to inode/directory in their desktop entry files and that hence all corresponding packages "want to run update-desktop-database" as well?
Comment by Doug Newgard (Scimmia) - Thursday, 31 March 2016, 18:02 GMT
Which means nothing to this package. If it doesn't access that cache, it doesn't care.

Loading...