Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#48754 - [lxqt-config] desktop entry files unusable due to additional lines added at build time

Attached to Project: Community Packages
Opened by Peter Mattern (krabat) - Wednesday, 30 March 2016, 14:32 GMT
Last edited by Jerome Leclanche (Adys) - Friday, 08 April 2016, 23:32 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Jerome Leclanche (Adys)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

All desktop entry files provided by lxqt-config except lxqt-config-locale.desktop are comprising lots of lines like
> Binary file /build/lxqt-config/src/lxqt-config-0.10.0/[...]
which are rendering the files unusable.

The lines seem to be due to some problem at build time affecting translations: Running 'makepkg -s' in a local ABS checkout of lxqt-config yields regular desktop entry files here, lxqt-config-locale wasn't translated in release 0.10 yet.
This task depends upon

Closed by  Jerome Leclanche (Adys)
Friday, 08 April 2016, 23:32 GMT
Reason for closing:  Fixed
Comment by Felix Yan (felixonmars) - Friday, 01 April 2016, 04:06 GMT
Looks like a patch to liblxqt is needed: https://github.com/lxde/lxqt/issues/957

Adding @Jerome as he's the maintainer.
Comment by Peter Mattern (krabat) - Friday, 01 April 2016, 19:47 GMT
Right.

Meanwhile we figured out on freenode #lxde that the problem seems to exist only when the built system's locale is C. (Which tricked me into not attributing this problem to the one affecting grep in the first place, btw.)
So a potential workaround is to re-compile the package on a system with some arbitrary UTF-8 locale. Don't know whether this is feasible.

But J. Leclanche was attending the channel as well so chances are he'll chime in soon and fix the problem.
Comment by Jerome Leclanche (Adys) - Friday, 01 April 2016, 19:51 GMT
It doesn't seem to be an issue with grep 2.24 (the current arch version). So I'm not sure we need to do anything here?
Comment by Jerome Leclanche (Adys) - Friday, 01 April 2016, 19:53 GMT
Ah sorry, I misread the second comment. If it's an issue with LOCALE=C, then there is indeed nothing to fix here. The packages are built on celestia with LANG=en_US.UTF-8.
Comment by Jerome Leclanche (Adys) - Friday, 01 April 2016, 19:54 GMT
I'll do a rebuild for good measure.
Comment by Peter Mattern (krabat) - Friday, 01 April 2016, 19:55 GMT
We need to as the packages currently delivered are featuring the broken desktop entry files.

Which locale was set when you compiled against grep 2.24? As said above my tests are strongly suggesting that the grep version doesn't matter as long as it's ≥ 2.23 but the locale does.
Comment by Jerome Leclanche (Adys) - Friday, 01 April 2016, 19:58 GMT
Yeah, I see the problem. I'm not sure why celestia is affected though. I'll look into it.
Comment by Jerome Leclanche (Adys) - Friday, 01 April 2016, 20:04 GMT
Figured it out. LC_ALL is unset. I'll rebuild.
Comment by Jerome Leclanche (Adys) - Friday, 01 April 2016, 20:22 GMT
Fixed in lxqt-common-0.10.0-3
Comment by James (thx1138) - Tuesday, 05 April 2016, 02:30 GMT
I'm confused - the comment about closing says "lxqt-common-0.10.0-3", but the problem was in lxqt-config 0.10.0-4, which has not yet been fixed. So is lxqt-config going to be fixed, or...?
Comment by Balló György (City-busz) - Friday, 08 April 2016, 22:56 GMT
@Jerome, I think the proper solution is:

1. Apply this patch for the lxqt-common package: https://github.com/lxde/liblxqt/commit/082321a.patch

2. Rebuild the lxqt-config package.
Comment by Jerome Leclanche (Adys) - Friday, 08 April 2016, 22:58 GMT
Sorry, I didn't see this get reopened. I did rebuilt lxqt-config as well. Both packages were affected. Did it not work?
Comment by Balló György (City-busz) - Friday, 08 April 2016, 23:14 GMT
This is not a complete solution, because if anyone rebuild any other LXQt components with LANG=C, then he gets a wrong package. So we have two options:

1. Apply the mentioned patch for the lxqt-common package.

2. Add the workaround for all LXQt packages, which contain .desktop files.
Comment by Jerome Leclanche (Adys) - Friday, 08 April 2016, 23:19 GMT
Why are rebuilds an issue?
Comment by Jerome Leclanche (Adys) - Friday, 08 April 2016, 23:20 GMT
PS, we're releasing in 6 weeks, so if it's solved in the main packages and the rest is not time sensitive I'd rather wait it out.
Comment by Balló György (City-busz) - Friday, 08 April 2016, 23:24 GMT
Because users may want to build the packages from ABS, and we should try to ensure that they get the same working package as we released in binary form.
Comment by Jerome Leclanche (Adys) - Friday, 08 April 2016, 23:32 GMT
So I'd say it's not worth the effort of further builds (and the risk of patching) since it just breaks translations in some languages, on some specific desktop files, specifically for users who built the packages themselves without applying a workaround, and will be gone within a month).

The main issue in the packages has been fixed so I'm closing again. Let me know if this causes further problems.

Loading...